-
-
Notifications
You must be signed in to change notification settings - Fork 84
Description
Bug Report Checklist
- I have tried restarting my IDE and the issue persists.
- I have pulled the latest
main
branch of the repository. - I have searched for related issues and found none that matched my issue.
Overview
Thanks to #1048, we see now that this repository has two bits of tooling that are different between its π actual files and π code templates (see Additional Info below for explanation of the emojis):
- π Actual files: Has a
"commitType": "docs"
:create-typescript-app/.all-contributorsrc
Line 367 in d66379b
"commitType": "docs" - π Code templates: Does not have a
"commitType": "docs"
:return await formatJson({
Docs for commitType
are being added in all-contributors/all-contributors.github.io#710 -> all-contributors/all-contributors.github.io#757. Seems that the default value is "docs"
. So there's no need to explicitly specify it the way this repo has been.
Let's remove any and all references to commitType
from this repo. Accepting PRs!
Additional Info
This repository is two things:
- π An example of a working TypeScript repository, including builds, Knip, package publishing, and more tooling
- π Code that can set up a new or existing repository using all of that repository tooling
For the most part, the repository's end-to-end test for --mode migration
makes sure that the π actual files and π code templates stay the same. As in, if one changes, the other needs to have the same change as well. But per #546, there are some files that were missed in that test. We're only now able to verify that they're the same as of #1048. That PR is where this discrepancy was discovered.