Skip to content

Conversation

@JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Jun 9, 2025

PR Checklist

Overview

Switches over, and includes intake/transition logic to remove the bundle property from old tsup.config.ts files.

Blocked from passing lint:spelling on streetsidesoftware/cspell-dicts#4518 -> #2237.

🎁

@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.80%. Comparing base (ac941e4) to head (66769f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2224   +/-   ##
=======================================
  Coverage   99.80%   99.80%           
=======================================
  Files         136      136           
  Lines        6099     6111   +12     
  Branches      505      509    +4     
=======================================
+ Hits         6087     6099   +12     
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg
Copy link
Owner Author

🙌 thanks for the review @TheAlexLichter! Now that this is unblocked I'll apply the suggestions. They're really helpful.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review June 26, 2025 03:04
@JoshuaKGoldberg JoshuaKGoldberg merged commit 5ea7d3e into main Jun 26, 2025
10 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the tsdown branch June 26, 2025 03:18
@github-actions
Copy link

🎉 This is included in version v2.46.0 🎉

The release is available on:

Cheers! 📦🚀

@johnnyreilly
Copy link
Collaborator

Nice! It looks like the switch from tsup to tsdown is pretty simple!

@TheAlexLichter
Copy link

Nice! It looks like the switch from tsup to tsdown is pretty simple!

That is one of the goals of tsdown - to be a "near" drop-in replacement (the few things that are different are listed in the migration guide)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 Feature: Switch from tsup to tsdown

4 participants