Skip to content

Commit aa35cb0

Browse files
committed
feat: add support for eslint v10
This change updates the version of eslint in our codebase to v10, and adds additional testing and typechecking in ci, running those steps on both v9 and v10.
1 parent 081114d commit aa35cb0

File tree

4 files changed

+191
-183
lines changed

4 files changed

+191
-183
lines changed

.github/workflows/ci.yml

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,14 @@ jobs:
4646
- uses: ./.github/actions/prepare
4747
- run: pnpm format --list-different
4848
test:
49-
name: Test (Node.js ${{ matrix.node-version }}, ${{ matrix.os }})
49+
name: Test (Node.js ${{ matrix.node-version }}, ESLint ${{ matrix.eslint-version }}, ${{ matrix.os }})
5050
runs-on: ${{ matrix.os }}
5151
strategy:
5252
fail-fast: false
5353
matrix:
54+
eslint-version:
55+
- 9
56+
- 10
5457
node-version:
5558
- 20
5659
- 22
@@ -63,15 +66,23 @@ jobs:
6366
- uses: ./.github/actions/prepare
6467
with:
6568
node-version: ${{ matrix.node-version }}
69+
- run: pnpm install -D eslint@${{ matrix.eslint-version }}
6670
- run: pnpm run test --coverage
6771
- env:
6872
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
6973
if: always()
7074
uses: codecov/codecov-action@v5
7175
type_check:
72-
name: Type Check
76+
name: Type Check (ESLint ${{ matrix.eslint-version }})
7377
runs-on: ubuntu-latest
78+
strategy:
79+
fail-fast: false
80+
matrix:
81+
eslint-version:
82+
- 9
83+
- 10
7484
steps:
7585
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
7686
- uses: ./.github/actions/prepare
87+
- run: pnpm install -D eslint@${{ matrix.eslint-version }}
7788
- run: pnpm typecheck

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
},
6969
"devDependencies": {
7070
"@eslint-community/eslint-plugin-eslint-comments": "4.6.0",
71-
"@eslint/js": "9.39.1",
71+
"@eslint/js": "10.0.1",
7272
"@eslint/markdown": "7.5.1",
7373
"@types/estree": "1.0.8",
7474
"@types/node": "24.10.1",
@@ -77,7 +77,7 @@
7777
"@vitest/coverage-v8": "4.0.13",
7878
"@vitest/eslint-plugin": "1.6.1",
7979
"console-fail-test": "0.6.0",
80-
"eslint": "9.39.1",
80+
"eslint": "10.0.0",
8181
"eslint-doc-generator": "3.0.2",
8282
"eslint-plugin-eslint-plugin": "7.3.0",
8383
"eslint-plugin-jsdoc": "62.5.0",

0 commit comments

Comments
 (0)