🐛 Bug: sort-collections resets indentation on scripts/etc

[Nick2bad4u]

Bug Report Checklist

• I have tried restarting my IDE and the issue persists.
• I have searched for related issues and found none that matched my issue.

Expected

Indentation shouldn't change when sorting things in package.json

Actual

When you run the:

        "package-json/scripts-name-casing": "warn",
            "package-json/sort-collections": [ "warn",
            [
                "config",
                "dependencies",
                "devDependencies",
                "exports",
                "optionalDependencies",
                // "overrides",
                "peerDependencies",
                "peerDependenciesMeta",
                "scripts"
            ],
        ],

(my config)

when it sorts the scripts, my indendation changes on the entire script block from:

Before:

        "lint:publint": "publint",

After:

    "lint:publint": "publint",

I use indentation of 4 spaces and it gets reset to 2 spaces pretty much

Version

eslint-plugin-package-json@0.88.2

ESLint Version

eslint@9.39.2

Additional Info

No response

[michaelfaith]

Yeah, we're not really making any attempt to match the indentation that's in there originally, since we don't have any knowledge of your format settings. We're sort of operating under the assumption that your formatter will run after linting and adjust the indentions based on your format settings. Is that not happening in your case?

[Nick2bad4u]

Yeah, we're not really making any attempt to match the indentation that's in there originally, since we don't have any knowledge of your format settings. We're sort of operating under the assumption that your formatter will run after linting and adjust the indentions based on your format settings. Is that not happening in your case?

Yes the formatter will fix it after you run it.

But would prefer if eslint would set the indentation correctly. (Rule options?)

[Nick2bad4u]

Yeah, we're not really making any attempt to match the indentation that's in there originally, since we don't have any knowledge of your format settings. We're sort of operating under the assumption that your formatter will run after linting and adjust the indentions based on your format settings. Is that not happening in your case?

Yes the formatter will fix it after you run it.

But would prefer if eslint would set the indentation correctly. (Rule options?)

[michaelfaith]

But this plugin (and ESLint more in general) isn't meant to be a formatter. So, while I think we could possibly do more in terms of "best effort" attempts at matching the original indentation, duplicating your formatter settings as rule options isn't really a road that I think makes sense to go down. We're not meant to be a formatter. I'll go ahead and mark this as Accepting PRs, but only for adding some "best effort" attempt at matching indents with the existing code (with the understanding that's it's not going to be perfect, and will rely on a formatter to run to correct any inconsistencies).

[JoshuaKGoldberg]

@all-contributors please add @Nick2bad4u for bug.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

[allcontributors]

@JoshuaKGoldberg

I've put up a pull request to add @Nick2bad4u! 🎉