Skip to content

Commit 031d1d3

Browse files
committed
Basic changes to make things more clear/etc.
1 parent b1482bd commit 031d1d3

File tree

5 files changed

+42
-23
lines changed

5 files changed

+42
-23
lines changed

lint.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
from pylint.lint import Run
44

55
if __name__ == "__main__":
6-
result = Run([sys.argv[1], f"--rcfile={sys.argv[2]}"], do_exit=False)
6+
result = Run([sys.argv[1], f"--rcfile={sys.argv[2]}"], exit=False)
77
exitCode = result.linter.msg_status
8-
rating = result.linter.stats["global_note"]
8+
rating = result.linter.stats.global_note
99

1010
if exitCode & 3 or rating < float(sys.argv[3]):
11-
sys.exit(exitCode)
11+
sys.exit(exitCode)

pyisotools/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
__version__ = "2.4.6"
1+
__version__ = "2.4.7"
22
__author__ = "JoshuaMK"
33
__credits__ = "Yet Another Gamecube Documentation"

pyisotools/gui/connector.py

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -730,9 +730,9 @@ def bnr_reset_info(self):
730730
for p in self.rootPath.rglob("*.bnr"):
731731
if p.is_file():
732732
with p.open("rb") as pp:
733-
self.bnrMap[
734-
p.relative_to(self.rootPath / "files")
735-
] = BNR.from_data(pp, size=p.stat().st_size)
733+
self.bnrMap[p.relative_to(self.rootPath / "files")] = (
734+
BNR.from_data(pp, size=p.stat().st_size)
735+
)
736736

737737
self.ui.bannerComboBox.clear()
738738
self.ui.bannerComboBox.addItems(
@@ -863,7 +863,7 @@ def help_about(self):
863863
"\n\n",
864864
"Please see the readme for more details.",
865865
"\n\n",
866-
"Copyright © 2023; All rights reserved.",
866+
"Copyright © 2025; All rights reserved.",
867867
"\n\n",
868868
"JoshuaMK <joshuamkw2002@gmail.com>",
869869
"\n\n",
@@ -886,6 +886,13 @@ def help_file_alignment(self):
886886
"\n\n",
887887
"Valid alignments:\n",
888888
"4, 8, 16, 32, 64, 128, 256, 512, 1024, 2048, 4096, 8192, 16384, 32768",
889+
"\n\n",
890+
"Note: There are recommended alignments for certain applications.\n",
891+
"For example, some games use streamed audio files (.adp) that require\n",
892+
"a 32768 alignment to adhere with the DVD streaming hardware.\n\n",
893+
"Still, other games are finniky and require 32 byte alignment\n",
894+
"of all files to work properly.\n\n",
895+
"File alignment is your friend; don't be afraid to experiment!",
889896
]
890897
)
891898

@@ -902,6 +909,17 @@ def help_file_position(self):
902909
"to set the internal ISO position of that node.",
903910
"\n\n",
904911
"Default position: -1",
912+
"\n\n",
913+
"This is a useful tool for exotic DVD optimizations.\n",
914+
"Files with a smaller/lower position are placed closer to\n",
915+
"the center of the DVD, while files with a larger/higher\n",
916+
"position are placed closer to the edge of the DVD.\n",
917+
"Since the outer edge of the DVD has a higher read speed,\n",
918+
"place lower priority (and smaller) files closer to the center\n",
919+
"by using a lower position, leaving room for larger files\n"
920+
"to be automatic placed at the edge of the DVD.",
921+
"\n\n",
922+
"Note: This feature is for advanced modding only!\n",
905923
]
906924
)
907925

@@ -915,7 +933,7 @@ def help_file_exclusion(self):
915933
info = "".join(
916934
[
917935
"When an extracted root is opened, you can right click on each node\n",
918-
"to set if it (and all children) is excluded from the build process.",
936+
"to set if it--and all its children--are excluded from the build process.",
919937
]
920938
)
921939

requirements.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,5 @@ pillow
77
pygithub
88
PySide6
99
pyinstaller
10+
pylint
11+
setuptools

setup.py

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import pyisotools
21
import setuptools
2+
import pyisotools
33

44
with open("README.md", "r", encoding="utf-8") as fh:
55
longDescription = fh.read()
@@ -8,25 +8,24 @@
88
requires = [x for x in r]
99

1010
setuptools.setup(
11-
name='pyisotools',
11+
name="pyisotools",
1212
version=pyisotools.__version__,
13-
description='Simple python library for extracting and rebuilding ISOs',
13+
description="Simple python library for extracting and rebuilding ISOs",
1414
long_description=longDescription,
1515
long_description_content_type="text/markdown",
16-
url='https://github.com/JoshuaMKW/pyisotools',
17-
author='JoshuaMK',
18-
author_email='joshuamkw2002@gmail.com',
19-
license='GNU General Public License v3.0',
16+
url="https://github.com/JoshuaMKW/pyisotools",
17+
author="JoshuaMK",
18+
author_email="joshuamkw2002@gmail.com",
19+
license="GNU General Public License v3.0",
2020
packages=setuptools.find_packages(),
2121
include_package_data=True,
2222
install_requires=requires,
23-
2423
classifiers=[
25-
'Development Status :: 4 - Beta',
26-
'Intended Audience :: Developers',
27-
'Programming Language :: Python :: 3.8',
28-
'License :: OSI Approved :: GNU General Public License v3 (GPLv3)',
29-
'Operating System :: OS Independent'
24+
"Development Status :: 4 - Beta",
25+
"Intended Audience :: Developers",
26+
"Programming Language :: Python :: 3.8",
27+
"License :: OSI Approved :: GNU General Public License v3 (GPLv3)",
28+
"Operating System :: OS Independent",
3029
],
31-
python_requires='>=3.8',
30+
python_requires=">=3.8",
3231
)

0 commit comments

Comments
 (0)