addressed review comments

Author: JoshwinThomasIBM

src/extension.ts

@@ -188,6 +188,10 @@ export function registerFileWatcher(projectProvider: ProjectProvider): void {
 	const watcher: vscode.FileSystemWatcher = vscode.workspace.createFileSystemWatcher("{**/pom.xml,**/build.gradle,**/settings.gradle,**/src/main/liberty/config/server.xml}");
     // Async handler for the file system events (create, change, delete)
     const handleUri = async (uri: vscode.Uri) => {
+        if (uri.fsPath.endsWith("server.xml")) {
+            await projectProvider.refresh();
+            return;
+        }
         const workspaceFolders = vscode.workspace.workspaceFolders;
 
         if (!workspaceFolders) {
@@ -210,16 +214,12 @@ export function registerFileWatcher(projectProvider: ProjectProvider): void {
                  * Determines the parent directory of the project root. 
                  * If a valid parent exists, use its path for searching. Otherwise, use the project root path itself.
                  */
-                try {
-                    let projectRootParent = path.dirname(projectRoot);
-                    if (fs.existsSync(projectRootParent) && fs.statSync(projectRootParent).isDirectory())
-                        projectRoot = projectRootParent;
-                    else
-                        console.debug("project root parent is not found ")
-                } catch (error) {
-                    console.error("project root parent is not found ");
+                let projectRootParent = path.dirname(projectRoot);
+                if (!(fs.existsSync(projectRootParent) && fs.statSync(projectRootParent).isDirectory())) {
+                    projectRootParent = projectRoot;// If the parent directory of the project root doesn't exist, set projectRootParent to projectRoot.
+                    console.debug("project root parent is not found ")
                 }
-                const siblingFileExists = await helperUtil.checkSiblingFilesInTargetOrBuildParent(uri.fsPath, projectRoot);
+                const siblingFileExists = await helperUtil.checkSiblingFilesInTargetOrBuildParent(uri.fsPath, projectRootParent);
                 if (!siblingFileExists) {
                     console.debug(`No sibling build file found, refreshing project... for  ` + uri.fsPath);
                     // Refresh the project if no sibling file is found

src/util/helperUtil.ts

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) 2020, 2024 IBM Corporation.
+ * Copyright (c) 2020, 2025 IBM Corporation.
  *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License v. 2.0 which is available at
@@ -102,7 +102,7 @@ export async function checkSiblingFilesInTargetOrBuildParent(filePath: string, p
 			outputDir = 'build';  // For Gradle projects, look for build directory
 			siblingFileType = 'build.gradle';
 		} else {
-			console.debug("Invalid file type. Only 'pom.xml' or 'build.gradle' are supported.");
+			console.debug("Invalid file type. Only 'pom.xml' or 'build.gradle' or 'settings.gradle' are supported.");
 			return false;
 		}
 
@@ -154,8 +154,9 @@ async function checkOutputDirAndSiblingBuildFile(currentDir: string, filePath: s
 			} else {
 				console.debug(" sibling not found " + siblingFilePath + " for " + filePath);
 			}
-		} else
+		} else{
 			console.debug(currentOutputDir + " is not found");
+		}
 		return false; // No sibling file found
 	} catch (err) {
 		console.error('Error during directory traversal in checkSiblingFileInDir:', err);