Merge pull request OpenLiberty#505 from gilbysunil14/Issue481-Green-Builds-Showing-Despite-Test-Failures

Issue 481 - Green Builds Showing Despite Test Failures

Author: aparnamichael

src/test/resources/ci/scripts/exec.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 
 ############################################################################
-# Copyright (c) 2022 IBM Corporation and others.
+# Copyright (c) 2022, 2025 IBM Corporation and others.
 # 
 # This program and the accompanying materials are made available under the
 # terms of the Eclipse Public License v. 2.0 which is available at
@@ -26,6 +26,9 @@ currentTime=(date +"%Y/%m/%d-%H:%M:%S:%3N")
 # Operating system.
 OS=$(uname -s)
 
+# Boolean to see if any failure has occured while executing commands
+failure="false"
+
 main() {
 
     setVscodeVersionToTest
@@ -40,6 +43,7 @@ main() {
         npm run build
         npm run compile
         vsce package
+        updateExitStatus
     else
 
         #Initialisation step
@@ -67,9 +71,12 @@ main() {
               chown -R runner  src/test/resources/gradle
                 # Gradle tests should be run before Maven tests because the after hook for copying the screeshots from temporary to a  permananet location is written in the Maven tests so that the copying will be done at the end of every test cases.
                 npm run test-mac-gradle -- -u
+                updateExitStatus
                 npm run test-mac-maven -- -u
+                updateExitStatus
             else
                 npm run test -- -u
+                updateExitStatus
             fi
         else
             # Run the plugin's install goal against the target vscode version
@@ -78,18 +85,19 @@ main() {
               chown -R runner  src/test/resources/gradle
               # Gradle tests should be run before Maven tests because the after hook for copying the screeshots from temporary to a  permananet location is written in the Maven tests so that the copying will be done at the end of every test cases.
               npm run test-mac-gradle -- -u -c $VSCODE_VERSION_TO_RUN
+              updateExitStatus
               npm run test-mac-maven -- -u -c $VSCODE_VERSION_TO_RUN
-
+              updateExitStatus
             else
             npm run test -- -u -c $VSCODE_VERSION_TO_RUN
+            updateExitStatus
             fi
         fi
     fi
 
     # If there were any errors, gather some debug data before exiting.
-    rc=$?
-    if [ "$rc" -ne 0 ]; then
-        echo "ERROR: Failure while driving npm install on plugin. rc: ${rc}."
+    if [ "$failure" = "true" ]; then
+        echo "ERROR: Failure occurred while running ${TYPE} step."
 
         if [ $TYPE = "TEST" ]; then
             echo "DEBUG: Maven Liberty messages.log:\n"
@@ -152,4 +160,13 @@ setVscodeVersionToTest() {
         fi
 }
 
+# Finding the exit status of a command and updating failure boolean.
+# Need to call this method after executing each npm command to store the status.
+updateExitStatus() {
+    status=$?
+    if [ "$failure" = "false" ] && [ $status -ne 0 ]; then
+        failure="true"
+    fi
+}
+
 main "$@"