Skip to content

Commit b33326a

Browse files
committed
Solve review comments
1 parent fb2d895 commit b33326a

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

Indicators/PythonIndicator.cs

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -57,19 +57,14 @@ public PythonIndicator(params PyObject[] args)
5757
public PythonIndicator(PyObject indicator)
5858
: base(GetIndicatorName(indicator))
5959
{
60-
InitializeIndicator(indicator);
60+
SetIndicator(indicator);
6161
}
6262

6363
/// <summary>
6464
/// Sets the python implementation of the indicator
6565
/// </summary>
6666
/// <param name="indicator">The python implementation of <see cref="IndicatorBase{IBaseDataBar}"/></param>
6767
public void SetIndicator(PyObject indicator)
68-
{
69-
InitializeIndicator(indicator);
70-
}
71-
72-
private void InitializeIndicator(PyObject indicator)
7368
{
7469
_instance = indicator;
7570
_indicatorWrapper = new BasePythonWrapper<IIndicator>(indicator, validateInterface: false);
@@ -88,11 +83,6 @@ private void InitializeIndicator(PyObject indicator)
8883
return;
8984
}
9085

91-
ValidateRequiredAttributes(indicator);
92-
}
93-
94-
private void ValidateRequiredAttributes(PyObject indicator)
95-
{
9686
var requiredAttributes = new[] { "IsReady", "Update", "Value" };
9787
foreach (var attributeName in requiredAttributes)
9888
{

0 commit comments

Comments
 (0)