We don't require keying by spread + arguments

This tends to comment https://github.com/graphql/graphql-js/pull/3835/files#r1100999816

Author: JoviDeCroock

src/execution/collectFields.ts

@@ -22,7 +22,6 @@ import {
 } from '../type/directives.js';
 import type { GraphQLSchema } from '../type/schema.js';
 
-import { keyForFragmentSpread } from '../utilities/keyForFragmentSpread.js';
 import { substituteFragmentArguments } from '../utilities/substituteFragmentArguments.js';
 import { typeFromAST } from '../utilities/typeFromAST.js';
 
@@ -44,7 +43,7 @@ interface CollectFieldsContext {
   variableValues: { [variable: string]: unknown };
   operation: OperationDefinitionNode;
   runtimeType: GraphQLObjectType;
-  visitedFragmentKeys: Set<string>;
+  visitedFragmentNames: Set<string>;
 }
 
 /**
@@ -70,7 +69,7 @@ export function collectFields(
     variableValues,
     runtimeType,
     operation,
-    visitedFragmentKeys: new Set(),
+    visitedFragmentNames: new Set(),
   };
 
   collectFieldsImpl(context, operation.selectionSet, groupedFieldSet);
@@ -102,7 +101,7 @@ export function collectSubfields(
     variableValues,
     runtimeType: returnType,
     operation,
-    visitedFragmentKeys: new Set(),
+    visitedFragmentNames: new Set(),
   };
   const subGroupedFieldSet = new AccumulatorMap<string, FieldDetails>();
 
@@ -134,7 +133,7 @@ function collectFieldsImpl(
     variableValues,
     runtimeType,
     operation,
-    visitedFragmentKeys,
+    visitedFragmentNames,
   } = context;
 
   for (const selection of selectionSet.selections) {
@@ -175,7 +174,7 @@ function collectFieldsImpl(
         break;
       }
       case Kind.FRAGMENT_SPREAD: {
-        const fragmentKey = keyForFragmentSpread(selection);
+        const fragmentName = selection.name.value;
 
         const newDeferUsage = getDeferUsage(
           operation,
@@ -186,13 +185,13 @@ function collectFieldsImpl(
 
         if (
           !newDeferUsage &&
-          (visitedFragmentKeys.has(fragmentKey) ||
+          (visitedFragmentNames.has(fragmentName) ||
             !shouldIncludeNode(variableValues, selection))
         ) {
           continue;
         }
 
-        const fragment = fragments[selection.name.value];
+        const fragment = fragments[fragmentName];
         if (
           fragment == null ||
           !doesFragmentConditionMatch(schema, fragment, runtimeType)
@@ -201,7 +200,7 @@ function collectFieldsImpl(
         }
 
         if (!newDeferUsage) {
-          visitedFragmentKeys.add(fragmentKey);
+          visitedFragmentNames.add(fragmentName);
         }
 
         const fragmentSelectionSet = substituteFragmentArguments(

src/utilities/keyForFragmentSpread.ts

@@ -11,8 +11,6 @@ import type {
 import { Kind } from '../language/kinds.js';
 import { visit } from '../language/visitor.js';
 
-// TODO: follow up on https://github.com/graphql/graphql-js/pull/3835/files#r1101010604
-
 /**
  * Replaces all fragment argument values with non-fragment-scoped values.
  *