Skip to content

Commit faf8d37

Browse files
authored
Merge pull request kubernetes#35223 from jackfrancis/dra-azure-comments
dra: add clarifying comments about azure + prom config
2 parents e870b46 + d648efe commit faf8d37

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

config/jobs/kubernetes/sig-scalability/DRA/sig-scalability-periodic-dra.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ periodics:
7272
value: "Standard_D8s_v3"
7373
- name: TEST_WINDOWS
7474
value: "false"
75-
- name: MONITORING_MACHINE_COUNT
76-
value: "1" # One monitoring machine for prometheus server
75+
- name: MONITORING_MACHINE_COUNT # This is the number of dedicated nodes for prometheus server
76+
value: "1" # We use the same VM size as control plane nodes, see CONTROL_PLANE_MACHINE_TYPE
7777
- name: AZURE_LOCATION
7878
value: "canadacentral" # Use canadacentral for proximity to prow container
7979
# Don't install Azure disk CSI driver as it's installed using a HelmChartProxy
@@ -194,8 +194,8 @@ periodics:
194194
value: "Standard_D8s_v3"
195195
- name: TEST_WINDOWS
196196
value: "false"
197-
- name: MONITORING_MACHINE_COUNT
198-
value: "1" # One monitoring machine for prometheus server
197+
- name: MONITORING_MACHINE_COUNT # This is the number of dedicated nodes for prometheus server
198+
value: "1" # We use the same VM size as control plane nodes, see CONTROL_PLANE_MACHINE_TYPE
199199
- name: AZURE_LOCATION
200200
value: "canadacentral" # Use canadacentral for proximity to prow container
201201
# Don't install Azure disk CSI driver as it's installed using a HelmChartProxy

config/jobs/kubernetes/sig-scalability/DRA/sig-scalability-presubmit-dra-capz.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ presubmits:
7272
value: "Standard_D8s_v3"
7373
- name: TEST_WINDOWS
7474
value: "false"
75-
- name: MONITORING_MACHINE_COUNT
76-
value: "1" # One monitoring machine for prometheus server
75+
- name: MONITORING_MACHINE_COUNT # This is the number of dedicated nodes for prometheus server
76+
value: "1" # We use the same VM size as control plane nodes, see CONTROL_PLANE_MACHINE_TYPE
7777
# Don't install Azure disk CSI driver as it's installed using a HelmChartProxy
7878
- name: DEPLOY_AZURE_CSI_DRIVER
7979
value: "false"
@@ -174,8 +174,8 @@ presubmits:
174174
value: "Standard_D8s_v3"
175175
- name: TEST_WINDOWS
176176
value: "false"
177-
- name: MONITORING_MACHINE_COUNT
178-
value: "1" # One monitoring machine for prometheus server
177+
- name: MONITORING_MACHINE_COUNT # This is the number of dedicated nodes for prometheus server
178+
value: "1" # We use the same VM size as control plane nodes, see CONTROL_PLANE_MACHINE_TYPE
179179
# Don't install Azure disk CSI driver as it's installed using a HelmChartProxy
180180
- name: DEPLOY_AZURE_CSI_DRIVER
181181
value: "false"
@@ -291,8 +291,8 @@ presubmits:
291291
value: "Standard_D2s_v3"
292292
- name: TEST_WINDOWS
293293
value: "false"
294-
- name: MONITORING_MACHINE_COUNT
295-
value: "1" # One monitoring machine for prometheus server
294+
- name: MONITORING_MACHINE_COUNT # This is the number of dedicated nodes for prometheus server
295+
value: "1" # We use the same VM size as control plane nodes, see CONTROL_PLANE_MACHINE_TYPE
296296
# Don't install Azure disk CSI driver as it's installed using a HelmChartProxy
297297
- name: DEPLOY_AZURE_CSI_DRIVER
298298
value: "false"

0 commit comments

Comments
 (0)