more tests to increase utilities.jl coverage

Author: ablaom

src/arrays.jl

@@ -135,7 +135,7 @@ function Base.Broadcast.broadcasted(
     u::UniFinArr{S,V,R,P,N},
     cv::CategoricalValue) where {S,V,R,P,N}
 
-    cv in classes(u) || _err_missing_class(cv)
+    cv in classes(u) || throw(err_missing_class(cv))
 
     f() = zeros(P, size(u)) #default caller function
 
@@ -161,7 +161,7 @@ function Base.Broadcast.broadcasted(
         "Arrays could not be broadcast to a common size; "*
         "got a dimension with lengths $(length(u)) and $(length(v))"))
     for cv in v
-        ismissing(cv) || cv in classes(u) || _err_missing_class(cv)
+        ismissing(cv) || cv in classes(u) || throw(err_missing_class(cv))
     end
 
     # will use linear indexing:

src/utilities.jl

@@ -140,12 +140,11 @@ decoder(x) = CategoricalDecoder(classes(x))
 
 ## TRANSFORMING BETWEEN CATEGORICAL ELEMENTS AND RAW VALUES
 
-_err_missing_class(c) =  throw(DomainError(
-    "Value `$c` not in pool"))
+err_missing_class(c) =  DomainError("Value `$c` not in pool")
 
 function _transform(pool, x)
     ismissing(x) && return missing
-    x in levels(pool) || _err_missing_class(x)
+    x in levels(pool) || throw(err_missing_class(x))
     return pool[get(pool, x)]
 end
 

test/utilities.jl

@@ -61,6 +61,11 @@ end
     @test int(v) == 1:3
     levels!(v, ['c', 'a', 'b'])
     @test int(v) == [2, 3, 1]
+    @test int(missing) |> ismissing
+    v_int = int(categorical(['a', missing]))
+    @test length(v_int) == 2
+    @test v_int[1] == 1
+    @test ismissing(v_int[2])
 
     # Errors
     @test_throws DomainError int("g")
@@ -74,6 +79,10 @@ end
 
     @test transform(element, missing) |> ismissing
 
+    # errors:
+    @test_throws(CategoricalDistributions.err_missing_class("non-existent"),
+                 transform(element, "non-existent"))
+
     raw = first(skipmissing(Xraw))
     c = transform(element, raw)
     @test Set(classes(c)) == Set(classes(X))
@@ -95,6 +104,11 @@ end
     @test Set(classes(C)) == Set(classes(X))
     @test identity.(skipmissing(C)) ==
         identity.(skipmissing(X[2:end-1,2:end-1]))
+
+    pool = CategoricalArrays.pool(element)
+    a = transform(element, 'a')
+    @test a == a
+    @test a isa CategoricalValue
 end
 
 end