Skip to content

Commit 25bb1e2

Browse files
committed
implement scitype to resolve #22
1 parent 20a7a69 commit 25bb1e2

File tree

5 files changed

+17
-4
lines changed

5 files changed

+17
-4
lines changed

src/CategoricalDistributions.jl

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,14 @@
11
module CategoricalDistributions
22

33
import Distributions
4-
import ScientificTypes: Finite, Multiclass, OrderedFactor, scitype, DefaultConvention
4+
import ScientificTypes:
5+
Finite,
6+
Multiclass,
7+
OrderedFactor,
8+
DefaultConvention,
9+
Density,
10+
ScientificTypesBase
11+
512
using OrderedCollections
613
using CategoricalArrays
714
import Missings
@@ -15,6 +22,7 @@ import Distributions: pdf, logpdf, support, mode
1522

1623
include("utilities.jl")
1724
include("types.jl")
25+
include("scitypes.jl")
1826
include("methods.jl")
1927
include("arrays.jl")
2028
include("arithmetic.jl")

test/arrays.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import Distributions
88
using StableRNGs
99
import Random
1010
using Missings
11-
using ScientificTypesBase
11+
using ScientificTypes
1212

1313
import CategoricalDistributions: classes
1414
import CategoricalArrays.unwrap

test/methods.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import Distributions
77
using StableRNGs
88
import Random
99
rng = StableRNG(123)
10-
using ScientificTypesBase
10+
using ScientificTypes
1111

1212
import CategoricalDistributions: classes
1313

test/runtests.jl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ using CategoricalDistributions
33
using CategoricalArrays
44
using Distributions
55
using Random
6+
using ScientificTypes
67
using StableRNGs # for RNGs stable across all julia versions
78
rng = StableRNGs.StableRNG(123)
89

@@ -16,6 +17,10 @@ end
1617
@test include("types.jl")
1718
end
1819

20+
@testset "scitypes" begin
21+
@test include("scitypes.jl")
22+
end
23+
1924
@testset "methods" begin
2025
@test include("methods.jl")
2126
end

test/types.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ using Test
44
using CategoricalDistributions
55
using CategoricalArrays
66
using StableRNGs
7-
using ScientificTypesBase
7+
using ScientificTypes
88
import Random
99

1010
# coverage of constructor testing is expanded in the other test files

0 commit comments

Comments
 (0)