Merge pull request #5 from JuliaAI/show

Add fancy `show` for UnivariateFinite

Author: ablaom

Project.toml

@@ -10,6 +10,7 @@ Missings = "e1d29d7a-bbdc-5cf2-9ac0-f12de2c33e28"
 OrderedCollections = "bac558e1-5e72-5ebc-8fee-abe8a469f55d"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 ScientificTypesBase = "30f210dd-8aff-4c5f-94ba-8e64358c1161"
+UnicodePlots = "b8865327-cd53-5732-bb35-84acbb429228"
 
 [compat]
 CategoricalArrays = "0.9, 0.10"

README.md

@@ -32,21 +32,28 @@ this package is the class pool of a `CategoricalArray`:
 ```julia
 using CategoricalDistributions
 using CategoricalArrays
+import Distributions
 julia> data = rand(["yes", "no", "maybe"], 10) |> categorical
 10-element CategoricalArray{String,1,UInt32}:
- "maybe"
- "maybe"
  "no"
  "yes"
- "maybe"
  "no"
+ "maybe"
+ "maybe"
  "no"
+ "maybe"
  "no"
  "no"
- "yes"
+ "maybe"
+
+julia> d = Distributions.fit(UnivariateFinite, data)
+               UnivariateFinite{Multiclass{3}}
+         ┌                                        ┐
+   maybe ┤■■■■■■■■■■■■■■■■■■■■■■■■■■■■ 0.4
+      no ┤■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■ 0.5
+     yes ┤■■■■■■■ 0.1
+         └                                        ┘
 
-julia> d = fit(UnivariateFinite, data)
-UnivariateFinite{Multiclass{3}}(maybe=>0.3, no=>0.5, yes=>0.2)
 
 julia> pdf(d, "no")
 0.5

src/CategoricalDistributions.jl

@@ -1,19 +1,14 @@
 module CategoricalDistributions
 
-export UnivariateFinite, UnivariateFiniteArray
-
-# re-eported from Distributions:
-export pdf, logpdf, support, mode
-
 import Distributions
-import ScientificTypesBase
+import ScientificTypesBase: Finite, Multiclass, OrderedFactor
 using OrderedCollections
 using CategoricalArrays
 import Missings
 using Random
+using UnicodePlots
 
 const Dist = Distributions
-const STB = ScientificTypesBase
 
 import Distributions: pdf, logpdf, support, mode
 
@@ -22,4 +17,12 @@ include("types.jl")
 include("methods.jl")
 include("arrays.jl")
 
+export UnivariateFinite, UnivariateFiniteArray
+
+# re-eport from Distributions:
+export pdf, logpdf, support, mode
+
+# re-export from ScientificTypesBase:
+export Multiclass, OrderedFactor
+
 end

src/methods.jl

@@ -79,6 +79,15 @@ function Base.show(stream::IO, d::UnivariateFinite)
     print(stream, "UnivariateFinite{$(d.scitype)}($arg_str)")
 end
 
+function Base.show(io::IO, mime::MIME"text/plain",
+                   d::UnivariateFinite{S}) where S
+    s = support(d)
+    x = string.(CategoricalArrays.DataAPI.unwrap.(s))
+    y = pdf.(d, s)
+    plt = barplot(x, y, title="UnivariateFinite{$S}")
+    show(io, mime, plt)
+end
+
 show_prefix(u::UnivariateFiniteArray{S,V,R,P,1}) where {S,V,R,P} =
     "$(length(u))-element"
 show_prefix(u::UnivariateFiniteArray) = join(size(u),'x')

src/types.jl

@@ -131,7 +131,7 @@ same size as the array.
 
 # extend Ditributions type hiearchy to account for non-euclidean
 # supports:
-abstract type Categorical{S<:STB.Finite} <: Dist.ValueSupport end
+abstract type Categorical{S<:Finite} <: Dist.ValueSupport end
 
 # not exported:
 const _UnivariateFinite_{S} =

src/utilities.jl

@@ -4,7 +4,7 @@
 
 function scitype(c::CategoricalValue)
     nc = length(levels(c.pool))
-    return ifelse(c.pool.ordered, STB.OrderedFactor{nc}, STB.Multiclass{nc})
+    return ifelse(c.pool.ordered, OrderedFactor{nc}, Multiclass{nc})
 end