factor out ERR_NAN_FOUND

Author: skleinbo

src/methods.jl

@@ -194,15 +194,15 @@ function Dist.modes(d::UnivariateFinite{S,V,R,P}) where {S,V,R,P}
     return d.decoder(M)
 end
 
+const ERR_NAN_FOUND = DomainError(
+    NaN,
+    "`mode(s)` is invalid for a `UnivariateFinite` distribution "*
+    "with `pdf` containing `NaN`s"
+)
+
 function throw_nan_error_if_needed(x)
     if isnan(x)
-        throw(
-            DomainError(
-                NaN,
-                "`mode(s)` is invalid for a `UnivariateFinite` distribution "*
-                "with `pdf` containing `NaN`s"
-            )
-        )
+        throw(ERR_NAN_FOUND)
     end
 end
 

test/arrays.jl

@@ -10,7 +10,7 @@ import Random
 using Missings
 using ScientificTypes
 
-import CategoricalDistributions: classes
+import CategoricalDistributions: classes, ERR_NAN_FOUND
 import CategoricalArrays.unwrap
 
 rng = StableRNG(111)
@@ -220,7 +220,7 @@ end
         ],
         pool=missing
     )
-    @test_throws DomainError mode.(unf_arr)
+    @test_throws ERR_NAN_FOUND mode.(unf_arr)
 end
 
 @testset "broadcasting modes" begin
@@ -261,7 +261,7 @@ end
         ],
         pool=missing
     )
-    @test_throws DomainError modes.(unf_arr)
+    @test_throws ERR_NAN_FOUND modes.(unf_arr)
 end
 
 @testset "cat for UnivariateFiniteArray" begin

test/methods.jl

@@ -9,7 +9,7 @@ import Random
 rng = StableRNG(123)
 using ScientificTypes
 
-import CategoricalDistributions: classes
+import CategoricalDistributions: classes, ERR_NAN_FOUND
 
 v = categorical(collect("asqfasqffqsaaaa"), ordered=true)
 V = categorical(collect("asqfasqffqsaaaa"))
@@ -181,7 +181,7 @@ end
 
     # `mode` of `Univariate` objects containing `NaN` in probs.
     unf = UnivariateFinite([0.1, 0.2, NaN, 0.1, NaN], pool=missing)
-    @test_throws DomainError mode(unf)
+    @test_throws ERR_NAN_FOUND mode(unf)
 end
 
 @testset "Univariate modes, bimodal" begin
@@ -195,7 +195,7 @@ end
 
     # `mode` of `Univariate` objects containing `NaN` in probs.
     unf = UnivariateFinite([0.1, 0.2, NaN, 0.1, NaN], pool=missing)
-    @test_throws DomainError modes(unf)
+    @test_throws ERR_NAN_FOUND modes(unf)
 end
 
 @testset "UnivariateFinite methods" begin