Skip to content

Commit c71298e

Browse files
committed
fix some mistakes
1 parent ac5419b commit c71298e

File tree

4 files changed

+8
-13
lines changed

4 files changed

+8
-13
lines changed

src/fit_update.jl

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,8 @@ LearnAPI.jl does not guarantee such signatures are actually implemented.
4444
$(DOC_DATA_INTERFACE(:fit))
4545
4646
"""
47-
fit(algorithm, data; kwargs...) =
48-
fit(algorithm; kwargs...)
49-
fit(algorithm, data1, datas...; kwargs...) =
50-
fit(algorithm, (data1, datas...); kwargs...)
47+
function fit end
48+
5149

5250
# # UPDATE AND COUSINS
5351

@@ -88,7 +86,7 @@ Implementation is optional. The signature must include
8886
See also [`LearnAPI.clone`](@ref)
8987
9088
"""
91-
update(model, data1, datas...; kwargs...) = update(model, (data1, datas...); kwargs...)
89+
function update end
9290

9391
"""
9492
update_observations(model, new_data; verbosity=1, parameter_replacements...)
@@ -124,8 +122,7 @@ Implementation is optional. The signature must include
124122
See also [`LearnAPI.clone`](@ref).
125123
126124
"""
127-
update_observations(algorithm, data1, datas...; kwargs...) =
128-
update_observations(algorithm, (data1, datas...); kwargs...)
125+
function update_observations end
129126

130127
"""
131128
update_features(model, new_data; verbosity=1, parameter_replacements...)
@@ -151,5 +148,4 @@ Implementation is optional. The signature must include
151148
See also [`LearnAPI.clone`](@ref).
152149
153150
"""
154-
update_features(algorithm, data1, datas...; kwargs...) =
155-
update_features(algorithm, (data1, datas...); kwargs...)
151+
function update_features end

src/predict_transform.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,8 @@ $(DOC_MUTATION(:transform))
166166
$(DOC_DATA_INTERFACE(:transform))
167167
168168
"""
169-
transform(model, data1, data2, datas...; kwargs...) =
170-
transform(model, (data1, data2, datas...); kwargs...) # automatic slurping
169+
function transform end
170+
171171

172172
"""
173173
inverse_transform(model, data)

test/patterns/ensembling.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ LearnAPI.strip(model::EnsembleFitted) = EnsembleFitted(
163163
# convenience method:
164164
LearnAPI.fit(algorithm::Ensemble, X, y, extras...; kwargs...) =
165165
fit(algorithm, (X, y, extras...); kwargs...)
166-
LearnAPI.update(algorithm::Ensemble, X, y, extras...; kwargs...) =
166+
LearnAPI.update(algorithm::EnsembleFitted, X, y, extras...; kwargs...) =
167167
update(algorithm, (X, y, extras...); kwargs...)
168168

169169

test/patterns/static_algorithms.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ end
5656
X = DataFrames.DataFrame(rand(3, 4), [:x, :y, :z, :w])
5757
model = fit(algorithm) # no data arguments!
5858
# if provided, data is ignored:
59-
@test fit(algorithm, "junk")[] == model[]
6059
@test LearnAPI.algorithm(model) == algorithm
6160
W = transform(model, X)
6261
@test W == DataFrames.DataFrame(Tables.matrix(X)[:,[1,4]], [:x, :w])

0 commit comments

Comments
 (0)