Merge pull request #19 from JuliaAI/test-cleanup

Test learner cleanup

Author: ablaom

Project.toml

@@ -1,7 +1,7 @@
 name = "LearnTestAPI"
 uuid = "3111ed91-c4f2-40e7-bb19-7f6c618409b8"
 authors = ["Anthony D. Blaom <[email protected]>"]
-version = "0.2.3"
+version = "0.2.4"
 
 [deps]
 CategoricalArrays = "324d7699-5711-5eae-9e2f-1d82baa6b597"

src/learners/regression.jl

@@ -28,12 +28,6 @@ LearnDataFrontEnds.jl.
 """
 Ridge(; lambda=0.1) = Ridge(lambda) # LearnAPI.constructor defined later
 
-struct RidgeFitObs{T,M<:AbstractArray{T}}
-    A::M  # p x n
-    names::Vector{Symbol}
-    y::Vector{T}
-end
-
 struct RidgeFitted{T,F}
     learner::Ridge
     coefficients::Vector{T}
@@ -43,10 +37,6 @@ end
 
 LearnAPI.learner(model::RidgeFitted) = model.learner
 
-Base.getindex(data::RidgeFitObs, I) =
-    RidgeFitObs(data.A[:,I], data.names, data.y[I])
-Base.length(data::RidgeFitObs) = length(data.y)
-
 # add a canned data front end; `obs` will return objects of type `FrontEnds.Obs`:
 const frontend = FrontEnds.Saffron(view=true)
 LearnAPI.obs(learner::Ridge, data) = FrontEnds.fitobs(learner, data, frontend)