Skip to content

Commit 0ac57fc

Browse files
committed
Implementing deleteruntag
1 parent f3e651c commit 0ac57fc

File tree

3 files changed

+55
-5
lines changed

3 files changed

+55
-5
lines changed

src/MLFlowClient.jl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,9 @@ export
6969
createrun,
7070
deleterun,
7171
setruntag,
72-
restorerun
72+
restorerun,
73+
deleteruntag
74+
7375
include("services/loggers.jl")
7476
export
7577
logbatch,

src/services/run.jl

Lines changed: 24 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,7 @@ end
102102
setruntag(instance::MLFlow, run_id::String, key::String, value::String)
103103
setruntag(instance::MLFlow, run::Run, key::String, value::String)
104104
105-
Set a tag on a run. Tags are run metadata that can be updated during a run and
106-
after a run completes.
105+
Set a tag on a run.
107106
108107
# Arguments
109108
- `instance`: [`MLFlow`](@ref) configuration.
@@ -114,10 +113,31 @@ after a run completes.
114113
# Returns
115114
`true` if successful. Otherwise, raises exception.
116115
"""
117-
function setruntag(instanceL::MLFlow, run_id::String, key::String,
116+
function setruntag(instance::MLFlow, run_id::String, key::String,
118117
value::String):Bool
119-
mlfpost(instanceL, "runs/set-tag"; run_id=run_id, key=key, value=value)
118+
mlfpost(instance, "runs/set-tag"; run_id=run_id, key=key, value=value)
120119
return true
121120
end
122121
setruntag(instance::MLFlow, run::Run, key::String, value::String)::Bool =
123122
setruntag(instance, run.info.run_id, key, value)
123+
124+
"""
125+
deletetag(instance::MLFlow, run_id::String, key::String)
126+
deletetag(instance::MLFlow, run::Run, key::String)
127+
128+
Delete a tag on a run.
129+
130+
# Arguments
131+
- `instance`: [`MLFlow`](@ref) configuration.
132+
- `run_id`: ID of the run that the tag was logged under.
133+
- `key`: Name of the tag.
134+
135+
# Returns
136+
`true` if successful. Otherwise, raises exception.
137+
"""
138+
function deleteruntag(instance::MLFlow, run_id::String, key::String)::Bool
139+
mlfpost(instance, "runs/delete-tag"; run_id=run_id, key=key)
140+
return true
141+
end
142+
deleteruntag(instance::MLFlow, run::Run, key::String)::Bool =
143+
deleteruntag(instance, run.info.run_id, key)

test/services/run.jl

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,3 +123,31 @@ end
123123

124124
deleteexperiment(mlf, experiment_id)
125125
end
126+
127+
@testset verbose = true "delete run tag" begin
128+
@ensuremlf
129+
experiment_id = createexperiment(mlf, UUIDs.uuid4() |> string)
130+
131+
@testset "delete tag with run string id" begin
132+
run = createrun(mlf, experiment_id)
133+
setruntag(mlf, run.info.run_id, "tag", "value")
134+
deleteruntag(mlf, run.info.run_id, "tag")
135+
136+
run = refresh(mlf, run)
137+
138+
@test (run.data.tags |> length) == 1 # The default tag
139+
deleterun(mlf, run)
140+
end
141+
142+
@testset "delete tag with run string id" begin
143+
run = createrun(mlf, experiment_id)
144+
setruntag(mlf, run, "tag", "value")
145+
deleteruntag(mlf, run, "tag")
146+
147+
run = refresh(mlf, run)
148+
149+
@test (run.data.tags |> length) == 1 # The default tag
150+
deleterun(mlf, run)
151+
end
152+
deleteexperiment(mlf, experiment_id)
153+
end

0 commit comments

Comments
 (0)