Skip to content

Commit 6bf2d8e

Browse files
authored
Merge pull request #68 from RomeoV/remove-logartifact-calls
Remove logartifact calls from tutorial and examples
2 parents ac9b7f7 + d8c3a12 commit 6bf2d8e

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

docs/src/tutorial.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,11 +105,12 @@ end
105105
plotfilename = "pricepaths-plot.png"
106106
png(plotfilename)
107107

108-
# Upload the plot as an artifact associated with the MLFlow experiment's run
109-
logartifact(mlf, exprun, plotfilename)
108+
# TODO: Upload the plot as an artifact when logartifact function is implemented
109+
# See: https://github.com/JuliaAI/MLFlowClient.jl/issues/61
110+
# logartifact(mlf, exprun, plotfilename)
110111

111-
# remote temporary plot which was already uploaded in MLFlow
112-
rm(plotfilename)
112+
# Keep the plot file since artifact upload is not yet available
113+
# rm(plotfilename)
113114

114115
# complete the experiment
115116
updaterun(mlf, exprun; status=RunStatus.FINISHED)

examples/simple-with-mlflow.jl

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,12 @@ end
5454
plotfilename = "pricepaths-plot.png"
5555
png(plotfilename)
5656

57-
# Upload the plot as an artifact associated with the MLFlow experiment's run
58-
logartifact(mlf, exprun, plotfilename)
57+
# TODO: Upload the plot as an artifact when logartifact function is implemented
58+
# See: https://github.com/JuliaAI/MLFlowClient.jl/issues/61
59+
# logartifact(mlf, exprun, plotfilename)
5960

60-
# remote temporary plot which was already uploaded in MLFlow
61-
rm(plotfilename)
61+
# Keep the plot file since artifact upload is not yet available
62+
# rm(plotfilename)
6263

6364
# complete the experiment
6465
updaterun(mlf, exprun; status=RunStatus.FINISHED)

0 commit comments

Comments
 (0)