Skip to content

Commit 70e97c8

Browse files
authored
Sending the executions in UTC-0 (resolves #20)
Sending the executions in UTC-0 (resolves #20)
1 parent d1afb2e commit 70e97c8

File tree

4 files changed

+24
-5
lines changed

4 files changed

+24
-5
lines changed

src/runs.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Creates a run associated to an experiment.
1717
function createrun(mlf::MLFlow, experiment_id; start_time=missing, tags=missing)
1818
endpoint = "runs/create"
1919
if ismissing(start_time)
20-
start_time = Int(trunc(datetime2unix(now()) * 1000))
20+
start_time = Int(trunc(datetime2unix(now(UTC)) * 1000))
2121
end
2222
result = mlfpost(mlf, endpoint; experiment_id=experiment_id, start_time=start_time, tags=tags)
2323
MLFlowRun(result["run"]["info"], result["run"]["data"])
@@ -69,7 +69,7 @@ function updaterun(mlf::MLFlow, run_id::String, status::MLFlowRunStatus; end_tim
6969
:end_time => end_time
7070
)
7171
if ismissing(end_time) && status.status == "FINISHED"
72-
end_time = Int(trunc(datetime2unix(now()) * 1000))
72+
end_time = Int(trunc(datetime2unix(now(UTC)) * 1000))
7373
kwargs[:end_time] = string(end_time)
7474
end
7575
result = mlfpost(mlf, endpoint; kwargs...)
@@ -233,7 +233,7 @@ Logs a metric value (or values) against a particular run.
233233
function logmetric(mlf::MLFlow, run_id::String, key, value::T; timestamp=missing, step=missing) where T<:Real
234234
endpoint = "runs/log-metric"
235235
if ismissing(timestamp)
236-
timestamp = Int(trunc(datetime2unix(now()) * 1000))
236+
timestamp = Int(trunc(datetime2unix(now(UTC)) * 1000))
237237
end
238238
mlfpost(mlf, endpoint; run_id=run_id, key=key, value=value, timestamp=timestamp, step=step)
239239
end

test/test_issue17.jl renamed to test/issues/test_issue17.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Addresses https://github.com/JuliaAI/MLFlowClient.jl/issues/17
2-
include("test_base.jl")
2+
include("../test_base.jl")
33

44
@testset "Issue17" begin
55
@ensuremlf

test/issues/test_issue20.jl

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# Addresses https://github.com/JuliaAI/MLFlowClient.jl/issues/20
2+
include("../test_base.jl")
3+
4+
@testset "Issue20" begin
5+
@ensuremlf
6+
7+
mlf_experiment = getorcreateexperiment(mlf, "issue20")
8+
mlf_run = createrun(
9+
mlf,
10+
mlf_experiment,
11+
tags=[
12+
Dict(
13+
"key" => "mlflow.runName",
14+
"value" => "run_name"
15+
)
16+
]
17+
)
18+
@test isa(mlf_run, MLFlowRun)
19+
end

test/runtests.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
include("test_functional.jl")
2-
include("test_issue17.jl")
2+
include.(filter(contains(r"\.jl$"), readdir("./issues"; join=true)))

0 commit comments

Comments
 (0)