Skip to content

Commit ebfcaee

Browse files
committed
Adding authentication to docker file.
1 parent c8c1e3e commit ebfcaee

File tree

3 files changed

+53
-50
lines changed

3 files changed

+53
-50
lines changed

docker-compose.test.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ services:
2424
"
2525
2626
mlflow:
27-
image: ghcr.io/mlflow/mlflow:v2.14.1
27+
image: ghcr.io/mlflow/mlflow:v3.6.0
2828
depends_on:
2929
- create-buckets
3030
ports:
@@ -33,11 +33,14 @@ services:
3333
- AWS_ACCESS_KEY_ID=minioadmin
3434
- AWS_SECRET_ACCESS_KEY=minioadmin
3535
- MLFLOW_S3_ENDPOINT_URL=http://minio:9000
36+
- MLFLOW_FLASK_SERVER_SECRET_KEY='mlflowclient.jl'
3637
command: >
3738
/bin/sh -c "
3839
pip install boto3 &&
40+
pip install mlflow[auth] &&
3941
mlflow server
4042
--host 0.0.0.0
4143
--port 5050
44+
--app-name basic-auth
4245
--default-artifact-root s3://mlflow
4346
"

test/runtests.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,4 @@ include("services/artifact.jl")
3838
include("services/experiment.jl")
3939
include("services/registered_model.jl")
4040
include("services/model_version.jl")
41-
#include("services/user.jl")
41+
include("services/user.jl")

test/services/experiment.jl

Lines changed: 48 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -217,54 +217,54 @@ end
217217

218218
# Disabling since /api/2.0/mlflow/users/create is no longer the right api to call.
219219
# This one is used by createuser
220-
#@testset verbose = true "create experiment permission" begin
221-
# @ensuremlf
222-
#
223-
# experiment_id = createexperiment(mlf, UUIDs.uuid4() |> string)
224-
# permission = Permission.parse("READ")
225-
#
226-
# @testset "with string experiment id" begin
227-
# user = createuser(mlf, "missy", "gala12345678")
228-
# experiment_permission =
229-
# createexperimentpermission(mlf, experiment_id, user.username, permission)
230-
#
231-
# @test experiment_permission isa ExperimentPermission
232-
# @test experiment_permission.experiment_id == experiment_id
233-
# @test experiment_permission.user_id == user.id
234-
# @test experiment_permission.permission == permission
235-
# deleteexperimentpermission(mlf, experiment_id, user.username)
236-
# deleteuser(mlf, user.username)
237-
# end
238-
#
239-
# @testset "with integer experiment id" begin
240-
# user = createuser(mlf, "missy", "gala12345678")
241-
# experiment_permission =
242-
# createexperimentpermission(mlf, parse(Int, experiment_id), user.username, permission)
243-
#
244-
# @test experiment_permission isa ExperimentPermission
245-
# @test experiment_permission.experiment_id == experiment_id
246-
# @test experiment_permission.user_id == user.id
247-
# @test experiment_permission.permission == permission
248-
# deleteexperimentpermission(mlf, experiment_id, user.username)
249-
# deleteuser(mlf, user.username)
250-
# end
251-
#
252-
# @testset "with Experiment" begin
253-
# experiment = getexperiment(mlf, experiment_id)
254-
# user = createuser(mlf, "missy", "gala12345678")
255-
# experiment_permission =
256-
# createexperimentpermission(mlf, experiment, user.username, permission)
257-
#
258-
# @test experiment_permission isa ExperimentPermission
259-
# @test experiment_permission.experiment_id == experiment_id
260-
# @test experiment_permission.user_id == user.id
261-
# @test experiment_permission.permission == permission
262-
# deleteexperimentpermission(mlf, experiment_id, user.username)
263-
# deleteuser(mlf, user.username)
264-
# end
265-
#
266-
# deleteexperiment(mlf, experiment_id)
267-
#end
220+
@testset verbose = true "create experiment permission" begin
221+
@ensuremlf
222+
223+
experiment_id = createexperiment(mlf, UUIDs.uuid4() |> string)
224+
permission = Permission.parse("READ")
225+
226+
@testset "with string experiment id" begin
227+
user = createuser(mlf, "missy", "gala12345678")
228+
experiment_permission =
229+
createexperimentpermission(mlf, experiment_id, user.username, permission)
230+
231+
@test experiment_permission isa ExperimentPermission
232+
@test experiment_permission.experiment_id == experiment_id
233+
@test experiment_permission.user_id == user.id
234+
@test experiment_permission.permission == permission
235+
deleteexperimentpermission(mlf, experiment_id, user.username)
236+
deleteuser(mlf, user.username)
237+
end
238+
239+
@testset "with integer experiment id" begin
240+
user = createuser(mlf, "missy", "gala12345678")
241+
experiment_permission =
242+
createexperimentpermission(mlf, parse(Int, experiment_id), user.username, permission)
243+
244+
@test experiment_permission isa ExperimentPermission
245+
@test experiment_permission.experiment_id == experiment_id
246+
@test experiment_permission.user_id == user.id
247+
@test experiment_permission.permission == permission
248+
deleteexperimentpermission(mlf, experiment_id, user.username)
249+
deleteuser(mlf, user.username)
250+
end
251+
252+
@testset "with Experiment" begin
253+
experiment = getexperiment(mlf, experiment_id)
254+
user = createuser(mlf, "missy", "gala12345678")
255+
experiment_permission =
256+
createexperimentpermission(mlf, experiment, user.username, permission)
257+
258+
@test experiment_permission isa ExperimentPermission
259+
@test experiment_permission.experiment_id == experiment_id
260+
@test experiment_permission.user_id == user.id
261+
@test experiment_permission.permission == permission
262+
deleteexperimentpermission(mlf, experiment_id, user.username)
263+
deleteuser(mlf, user.username)
264+
end
265+
266+
deleteexperiment(mlf, experiment_id)
267+
end
268268
#
269269
#@testset verbose = true "get experiment permission" begin
270270
# @ensuremlf

0 commit comments

Comments
 (0)