From d8c3a12124a9e6a06c3a2ad9f0511fff013e8fa2 Mon Sep 17 00:00:00 2001 From: Romeo Valentin Date: Tue, 2 Sep 2025 16:57:10 +0200 Subject: [PATCH] Remove logartifact calls from tutorial and examples MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Removes calls to the non-existent logartifact function that was causing UndefVarError. The function is not implemented in the current codebase. Changes: - Commented out logartifact calls with TODO reference to issue #61 - Commented out rm(plotfilename) to keep plot files available - Added clear comments explaining the temporary workaround This makes the tutorial functional while preserving the intent for future implementation when artifact upload functionality is added. Fixes #61 (temporary workaround until function is implemented) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- docs/src/tutorial.md | 9 +++++---- examples/simple-with-mlflow.jl | 9 +++++---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/docs/src/tutorial.md b/docs/src/tutorial.md index d7565c3..d11dad1 100644 --- a/docs/src/tutorial.md +++ b/docs/src/tutorial.md @@ -102,11 +102,12 @@ end plotfilename = "pricepaths-plot.png" png(plotfilename) -# Upload the plot as an artifact associated with the MLFlow experiment's run -logartifact(mlf, exprun, plotfilename) +# TODO: Upload the plot as an artifact when logartifact function is implemented +# See: https://github.com/JuliaAI/MLFlowClient.jl/issues/61 +# logartifact(mlf, exprun, plotfilename) -# remote temporary plot which was already uploaded in MLFlow -rm(plotfilename) +# Keep the plot file since artifact upload is not yet available +# rm(plotfilename) # complete the experiment updaterun(mlf, exprun, "FINISHED") diff --git a/examples/simple-with-mlflow.jl b/examples/simple-with-mlflow.jl index 13990f0..3c1145d 100644 --- a/examples/simple-with-mlflow.jl +++ b/examples/simple-with-mlflow.jl @@ -51,11 +51,12 @@ end plotfilename = "pricepaths-plot.png" png(plotfilename) -# Upload the plot as an artifact associated with the MLFlow experiment's run -logartifact(mlf, exprun, plotfilename) +# TODO: Upload the plot as an artifact when logartifact function is implemented +# See: https://github.com/JuliaAI/MLFlowClient.jl/issues/61 +# logartifact(mlf, exprun, plotfilename) -# remote temporary plot which was already uploaded in MLFlow -rm(plotfilename) +# Keep the plot file since artifact upload is not yet available +# rm(plotfilename) # complete the experiment updaterun(mlf, exprun, "FINISHED")