Skip to content

Commit 07a6bfe

Browse files
authored
Merge pull request #1165 from JuliaAI/rm-symbolic-regression-from-integration-tests
Rm symbolic regression from integration tests
2 parents 552c5e3 + d7d1d5a commit 07a6bfe

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "MLJ"
22
uuid = "add582a8-e3ab-11e8-2d5e-e98b27df1bc7"
33
authors = ["Anthony D. Blaom <[email protected]>"]
4-
version = "0.20.7"
4+
version = "0.20.8"
55

66
[deps]
77
CategoricalArrays = "324d7699-5711-5eae-9e2f-1d82baa6b597"

test/integration.jl

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,9 @@ FILTER_GIVEN_ISSUE = Dict(
4444
"MultiTaskLassoCVRegressor",
4545
"MultiTaskLassoRegressor",
4646
],
47-
"https://github.com/JuliaAI/FeatureSelection.jl/issues/15" =>
48-
model -> model.package_name == "FeatureSelection" &&
49-
model.name == "RecursiveFeatureElimination",
5047
"https://github.com/sylvaticus/BetaML.jl/issues/75" =>
5148
model -> model.package_name == "BetaML" &&
5249
model.name == "NeuralNetworkClassifier",
53-
"https://github.com/MilesCranmer/SymbolicRegression.jl/issues/390" =>
54-
model -> model.package_name == "SymbolicRegression" &&
55-
model.name == "SRRegressor",
5650
# "https://github.com/JuliaAI/Imbalance.jl/issues/103" =>
5751
# model -> model.package_name == "Imbalance",
5852
)
@@ -140,7 +134,8 @@ for model in WITHOUT_DATASETS
140134
end
141135

142136
# Additionally exclude some models for which the inferred datasets have a model-specific
143-
# pathology that prevents valid generic test.
137+
# pathology that prevents valid generic test, or for some other reason requiring complete
138+
# exclusion from testing.
144139

145140
PATHOLOGIES = filter(MODELS) do model
146141
# in the subsampling occuring in stacking, we get a Cholesky
@@ -156,10 +151,8 @@ PATHOLOGIES = filter(MODELS) do model
156151
(model.name == "LOCIDetector" && model.package_name == "OutlierDetectionPython") ||
157152
# TO REDUCE TESTING TIME
158153
model.package_name == "MLJScikitLearnInterface" ||
159-
# can be removed after resolution of
160-
# https://github.com/JuliaAI/FeatureSelection.jl/issues/15
161-
# and a Model Registry update
162-
model.name == "RecursiveFeatureElimination"
154+
# "https://github.com/MilesCranmer/SymbolicRegression.jl/issues/390" =>
155+
model.package_name == "SymbolicRegression"
163156
end
164157

165158
WITHOUT_DATASETS = vcat(WITHOUT_DATASETS, PATHOLOGIES)

0 commit comments

Comments
 (0)