Skip to content

Commit 11ab73f

Browse files
committed
dump MLJBase from testing as MLJScientificTypes suffices
1 parent c68744d commit 11ab73f

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

Project.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,9 @@ CategoricalArrays = "324d7699-5711-5eae-9e2f-1d82baa6b597"
1616
DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
1717
Distances = "b4f34e82-e78d-54a5-968a-f98e89d6e8f7"
1818
InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
19-
MLJBase = "a7f614a8-145f-11e9-1d2a-a57a1082229d"
2019
MLJScientificTypes = "2e2323e0-db8b-457b-ae0d-bdfb3bc63afd"
2120
Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"
2221
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
2322

2423
[targets]
25-
test = ["Test", "Tables", "Distances", "CategoricalArrays", "InteractiveUtils", "DataFrames", "MLJScientificTypes", "MLJBase"]
24+
test = ["Test", "Tables", "Distances", "CategoricalArrays", "InteractiveUtils", "DataFrames", "MLJScientificTypes"]

src/parameter_inspection.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ istransparent(::MLJType) = true
66
77
Recursively convert any transparent object `m` into a named tuple,
88
keyed on the fields of `m`. An object is *transparent* if
9-
`MLJBase.istransparent(m) == true`. The named tuple is possibly nested
10-
because `params` is recursively applied to the field values, which
11-
themselves might be transparent.
9+
`MLJModelInterface.istransparent(m) == true`. The named tuple is
10+
possibly nested because `params` is recursively applied to the field
11+
values, which themselves might be transparent.
1212
1313
Most objects of type `MLJType` are transparent.
1414

test/data_utils.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@ end
7070
setfull()
7171
ary = rand(10, 3)
7272
@test M.schema(ary) === nothing
73-
M.schema(::FI, ::Val{:table}, X; kw...) = MLJBase.schema(X; kw...) # this would be defined in MLJBase.jl
73+
M.schema(::FI, ::Val{:table}, X; kw...) =
74+
MLJScientificTypes.schema(X; kw...)
7475
df = DataFrame(A = rand(10), B = categorical(rand('a':'c', 10)))
7576
sch = M.schema(df)
7677
@test sch.names == (:A, :B)

test/runtests.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ using Test, MLJModelInterface
22
using ScientificTypes, MLJScientificTypes
33
using Tables, Distances, CategoricalArrays, InteractiveUtils
44
import DataFrames: DataFrame
5-
import MLJBase
65

76
const M = MLJModelInterface
87
const FI = M.FullInterface

0 commit comments

Comments
 (0)