Skip to content

Commit 1628202

Browse files
committed
Merge branch 'master' into dev
2 parents 83d49a8 + e8da6ba commit 1628202

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

test/model_api.jl

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,13 @@ M.feature_importances(::APIx0, fitresult, report) = [:a=>0, :b=>0]
4646

4747
# training losses:
4848
f, c, r = MLJModelInterface.fit(m0, 1, rand(2), rand(2))
49-
@test M.training_losses(m0, r) == [1.0, 2.0, 3.0]
49+
@test M.training_losses(m0, r) == dummy_losses
5050

51-
# intrinsic_importances
51+
# training losses:
52+
f, c, r = MLJModelInterface.fit(m0, 1, rand(2), rand(2))
53+
@test M.training_losses(m0, r) == dummy_losses
54+
55+
# feature_importances
5256
f, c, r = MLJModelInterface.fit(m0, 1, rand(2), rand(2))
5357
@test MLJModelInterface.feature_importances(m0, f, r) == [:a=>0, :b=>0]
5458
end
@@ -75,7 +79,7 @@ mutable struct UnivariateFiniteFitter <: Probabilistic end
7579
end
7680

7781
MMI.input_scitype(::Type{<:UnivariateFiniteFitter}) = Nothing
78-
82+
7983
MMI.target_scitype(::Type{<:UnivariateFiniteFitter}) = AbstractVector{<:Finite}
8084

8185
y = categorical(collect("aabbccaa"))

0 commit comments

Comments
 (0)