Merge pull request #82 from alan-turing-institute/dev

For a 0.3.8 release

Author: ablaom

Project.toml

@@ -1,7 +1,7 @@
 name = "MLJModelInterface"
 uuid = "e80e1ace-859a-464e-9ed9-23947d8ae3ea"
 authors = ["Thibaut Lienart and Anthony Blaom"]
-version = "0.3.7"
+version = "0.3.8"
 
 [deps]
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"

src/model_traits.jl

@@ -36,9 +36,14 @@ docstring(M::Type{<:MLJType})  = name(M)
 docstring(M::Type{<:Model})    = "$(name(M)) from $(package_name(M)).jl.\n" *
                                  "[Documentation]($(package_url(M)))."
 # "derived" traits:
-name(M::Type)            = string(M)
-name(M::Type{<:MLJType}) = split(string(coretype(M)), '.')[end] |> String
-
+function _coretype(M)
+    if isdefined(M, :name)
+        return M.name.name
+    else
+        return _coretype(M.body)
+    end
+end
+name(M::Type)                            = string(_coretype(M))
 is_supervised(::Type)                    = false
 is_supervised(::Type{<:Supervised})      = true
 prediction_type(::Type)                  = :unknown # used for measures too

src/utils.jl

@@ -2,10 +2,3 @@ if VERSION < v"1.1"
     fieldtypes(t) = Tuple(fieldtype(t, i) for i = 1:fieldcount(t))
 end
 
-function coretype(M)
-    if isdefined(M, :name)
-        return M.name
-    else
-        return coretype(M.body)
-    end
-end

test/model_traits.jl

@@ -64,13 +64,27 @@ bar(::P1) = nothing
     @test Set(implemented_methods(mp)) == Set([:clean!,:bar,:foo])
 end
 
-struct FooMeasure <: MLJType end
+module Fruit
+
+import MLJModelInterface.MLJType
+
+struct Banana <: MLJType end
+struct Apple end
+
+end
+
+import .Banana
 
 @testset "extras" begin
     @test docstring(Float64) == "Float64"
-    @test docstring(FooMeasure) == "FooMeasure"
+    @test docstring(Fruit.Banana) == "Banana"
     @test name(Float64) == "Float64"
 
     df = DataFrame(a=randn(2), b=randn(2))
-    @test string(M.coretype(typeof(df))) == "DataFrame"
+    @test M.name(typeof(df)) == "DataFrame"
+    @test M.name(df) == "DataFrame"
+    @test M.name(Fruit.Banana) == "Banana"
+    @test M.name(Fruit.Banana()) == "Banana"
+    @test M.name(Fruit.Apple) == "Apple"
+    @test M.name(Fruit.Apple()) == "Apple"
 end