Merge pull request #149 from rikhuijzer/rh/fix-escape

Escape `MLJModelInterface` in quote

Author: ablaom

src/metadata_utils.jl

@@ -44,12 +44,12 @@ function metadata_pkg(
     package_license=license,
 )
     ex = quote
-        MLJModelInterface.package_name(::Type{<:$T}) = $package_name
-        MLJModelInterface.package_uuid(::Type{<:$T}) = $package_uuid
-        MLJModelInterface.package_url(::Type{<:$T}) = $package_url
-        MLJModelInterface.is_pure_julia(::Type{<:$T}) = $is_pure_julia
-        MLJModelInterface.package_license(::Type{<:$T}) = $package_license
-        MLJModelInterface.is_wrapper(::Type{<:$T}) = $is_wrapper
+        $MLJModelInterface.package_name(::Type{<:$T}) = $package_name
+        $MLJModelInterface.package_uuid(::Type{<:$T}) = $package_uuid
+        $MLJModelInterface.package_url(::Type{<:$T}) = $package_url
+        $MLJModelInterface.is_pure_julia(::Type{<:$T}) = $is_pure_julia
+        $MLJModelInterface.package_license(::Type{<:$T}) = $package_license
+        $MLJModelInterface.is_wrapper(::Type{<:$T}) = $is_wrapper
     end
     parentmodule(T).eval(ex)
 end
@@ -59,7 +59,7 @@ end
 function _extend!(program::Expr, trait::Symbol, value, T)
     if value !== nothing
         push!(program.args, quote
-              MLJModelInterface.$trait(::Type{<:$T}) = $value
+              $MLJModelInterface.$trait(::Type{<:$T}) = $value
               end)
         return nothing
     end

test/data_utils.jl

@@ -318,3 +318,14 @@ end
     @test_throws M.InterfaceError UnivariateFinite(Dict(2=>3, 3=>4))
     @test_throws M.InterfaceError UnivariateFinite(randn(2), randn(2))
 end
+
+@testset "not assuming MLJModelInterface symbol at user-side" begin
+    eval(:(module UserSide
+            import MLJModelInterface: metadata_model, metadata_pkg
+            struct A end
+            descr = "something"
+            # Smoke tests.
+            metadata_model(A; descr=descr)
+            metadata_pkg(A)
+    end))
+end