-
Notifications
You must be signed in to change notification settings - Fork 29
Extend support in DeterministicConstantRegressor to multitargets
#602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #602 +/- ##
==========================================
+ Coverage 76.93% 78.77% +1.83%
==========================================
Files 8 8
Lines 477 490 +13
==========================================
+ Hits 367 386 +19
+ Misses 110 104 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/builtins/Constant.jl
Outdated
| This "dummy" predictor always makes the same prediction, irrespective of the provided | ||
| input pattern, namely the mean value of the training target values. (It's counterpart, | ||
| `ConstantRegressor` makes probabilistic predictions.) This model handles mutlitargets, | ||
| i.e, the training target can be a matrix or a table (observations the rows). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems likes there is a typo here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, where?
OkonSamuel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!! I just made a couple of minor suggestions.
|
I realize I also need to:
|
Co-authored-by: Okon Samuel <[email protected]>
…lan-turing-institute/MLJModels.jl into multitarget-constant-regressor
After this PR, one can use
DeterministicConstantRegressorwith multitargets:It also adds tests and a docstring, which this model never had.