found bug

Author: josephsdavid

src/MLJMultivariateStatsInterface.jl

@@ -448,7 +448,6 @@ Where
 
 # Hyper-parameters
 
-# XXX: Would it be more consistent to use nothing or something as default?
 - `maxoutdim=0`: The maximum number of output dimensions. If not set, defaults to
   0, where all components are kept (e.g., the number of components/output dimensions
   is equal to the size of the smallest dimension of the training matrix)
@@ -464,7 +463,7 @@ Where
 
 # Operations
 
-- `predict(mach, Xnew)`: Return predictions of the target given new
+- `transform(mach, Xnew)`: Return predictions of the target given new
   features `Xnew` having the same Scitype as `X` above.
 
 # Fitted parameters
@@ -481,6 +480,10 @@ using MLJ
 
 PCA = @load PCA pkg=MultivariateStats
 
+X, y = @load_iris
+model = PCA(maxoutdim=2)
+mach = machine(pca, X) |> fit!
+
 ```
 
 See also

src/models/decomposition_models.jl

@@ -43,8 +43,8 @@ function MMI.fit(model::PCA, verbosity::Int, X)
     )
     cache = nothing
     report = (
-        indim=MS.size(fitresult,1),
-        outdim=MS.size(fitresult,2),
+        indim=MS.size(fitresult)[1],
+        outdim=MS.size(fitresult)[2],
         tprincipalvar=MS.tprincipalvar(fitresult),
         tresidualvar=MS.tresidualvar(fitresult),
         tvar=MS.var(fitresult),