Skip to content

Commit a495da5

Browse files
committed
making progress
1 parent 49b1273 commit a495da5

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/MLJMultivariateStatsInterface.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -921,7 +921,7 @@ Where
921921
922922
The fields of `fitted_params(mach)` are:
923923
924-
BUG: RENAME
924+
BUG: RENAME, Make note on top of PR for inconsistency
925925
- `class_means`: The matrix comprised of class-specific means as
926926
columns (of size `(d,m)`), where d corresponds to input features and m corresponds to class.
927927
- `projection_matrix`: The matrix used to project `X` into a lower dimensional space.

src/models/decomposition_models.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ function MMI.fit(model::PCA, verbosity::Int, X)
4343
)
4444
cache = nothing
4545
report = (
46-
# TODO: Make PR to MultivariateStats
47-
indim=MS.size(fitresult)[1],
46+
indim=MS.size(fitresult)[1]
4847
outdim=MS.size(fitresult)[2],
4948
tprincipalvar=MS.tprincipalvar(fitresult),
5049
tresidualvar=MS.tresidualvar(fitresult),

0 commit comments

Comments
 (0)