-
Notifications
You must be signed in to change notification settings - Fork 1
updated deps #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated deps #29
Conversation
@PasoStudio73 Thanks for taking initiative here and giving this package some TLC. Also good to get the positive feedback. I will aim to review this in a day or so. |
To fix the fail showing here, we need to change |
Had a first look at this. I'm all for eliminating test/Project.toml. However, don't you need to add some packages under |
BTW, I've given CompatHelper a kick. |
@ablaom thank you for your quick reply. |
Looks like you still need to add Distributed to [extras] and [target] in the project file. |
@ablaom thanks for your patience. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #29 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 253 257 +4
=========================================
+ Hits 253 257 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Anthony Blaom, PhD <[email protected]>
Project.toml
Outdated
MLJTuning = "0.6, 0.7" | ||
julia = "1.6" | ||
LinearAlgebra = "1" | ||
MLJBase = "1.7 - 1.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed this one earlier. If we change this as below then 1.0 and everything < 2.0 will be accepted. Nothing < 2.0 should be breaking, and we won't have added any features to MLJBase that this repo will know about. So this should be good.
MLJBase = "1.7 - 1.8" | |
MLJBase = "1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations, we have passing tests! I've sent you an invite for maintainer status. You shouldn't need to wait for me to run CI manually from now on an can probably push branches directly to the repo in future.
I'm happy with this subject to the last detail just flagged.
Thanks again!!
Wow, thank you so much @ablaom I feel honoured of this! Keep in touch!!! |
@PasoStudio73 The new release 0.1.4 has now been registered. |
Hi!
I'm working on a project at University of Ferrara, Italy:
https://github.com/aclai-lab/SoleXplorer.jl
and I found issues with this amazing package: deps.
I've managed to update deps, to have everything working smooth and fix some stuff on tests to have them working 100%.
Thanks! Riccardo Pasini