Skip to content

Conversation

PasoStudio73
Copy link
Collaborator

Hi!
I'm working on a project at University of Ferrara, Italy:
https://github.com/aclai-lab/SoleXplorer.jl
and I found issues with this amazing package: deps.
I've managed to update deps, to have everything working smooth and fix some stuff on tests to have them working 100%.
Thanks! Riccardo Pasini

@ablaom
Copy link
Member

ablaom commented May 5, 2025

@PasoStudio73 Thanks for taking initiative here and giving this package some TLC. Also good to get the positive feedback. I will aim to review this in a day or so.

@ablaom
Copy link
Member

ablaom commented May 5, 2025

To fix the fail showing here, we need to change actions/cache@v1 to julia-actions/cache@v1 in "/.github/workflows/ci.yml".

@ablaom
Copy link
Member

ablaom commented May 6, 2025

Had a first look at this. I'm all for eliminating test/Project.toml. However, don't you need to add some packages under [extras] and [targets] in the main Project.toml? Not sure how @everywhere can be working without using Distributed.

@ablaom
Copy link
Member

ablaom commented May 6, 2025

BTW, I've given CompatHelper a kick.

@PasoStudio73
Copy link
Collaborator Author

@ablaom thank you for your quick reply.
Maybe I had should wait for a better knowledgement of how CI works, and then open this PR, sorry.
Also, i forgot Distributed: that was a mistake.
I've fixed every point you noticed and now, locally, tests are fully ok.
Please take a look at CI.yml, not sure if it really needs changing.
Thank you so much and sorry for my poor English

@ablaom
Copy link
Member

ablaom commented May 7, 2025

Looks like you still need to add Distributed to [extras] and [target] in the project file.

@PasoStudio73
Copy link
Collaborator Author

@ablaom thanks for your patience.

Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (864d2b4) to head (b522d42).
Report is 10 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          253       257    +4     
=========================================
+ Hits           253       257    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Anthony Blaom, PhD <[email protected]>
Project.toml Outdated
MLJTuning = "0.6, 0.7"
julia = "1.6"
LinearAlgebra = "1"
MLJBase = "1.7 - 1.8"
Copy link
Member

@ablaom ablaom May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this one earlier. If we change this as below then 1.0 and everything < 2.0 will be accepted. Nothing < 2.0 should be breaking, and we won't have added any features to MLJBase that this repo will know about. So this should be good.

Suggested change
MLJBase = "1.7 - 1.8"
MLJBase = "1"

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations, we have passing tests! I've sent you an invite for maintainer status. You shouldn't need to wait for me to run CI manually from now on an can probably push branches directly to the repo in future.

I'm happy with this subject to the last detail just flagged.

Thanks again!!

@PasoStudio73
Copy link
Collaborator Author

Congratulations, we have passing tests! I've sent you an invite for maintainer status. You shouldn't need to wait for me to run CI manually from now on an can probably push branches directly to the repo in future.

I'm happy with this subject to the last detail just flagged.

Thanks again!!

Wow, thank you so much @ablaom I feel honoured of this! Keep in touch!!!

@ablaom ablaom merged commit b4e4adb into JuliaAI:dev May 8, 2025
4 checks passed
@ablaom ablaom mentioned this pull request May 8, 2025
@ablaom
Copy link
Member

ablaom commented May 8, 2025

@PasoStudio73 The new release 0.1.4 has now been registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants