Skip to content

Commit a7424c0

Browse files
committed
tweaks
1 parent a39c2d8 commit a7424c0

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

examples/bigtest/Project.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ EvoTrees = "f6006082-12f8-11e9-0c9c-0d5d367ab1e5"
55
InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
66
LightGBM = "7acf609c-83a4-11e9-1ffb-b912bcd3b04a"
77
MLJ = "add582a8-e3ab-11e8-2d5e-e98b27df1bc7"
8-
MLJBase = "a7f614a8-145f-11e9-1d2a-a57a1082229d"
98
MLJClusteringInterface = "d354fa79-ed1c-40d4-88ef-b8c7bd1568af"
109
MLJDecisionTreeInterface = "c6f25543-311c-4c74-83dc-3ea6d1015661"
1110
MLJFlux = "094fc8d1-fd35-5302-93ea-dabda2abf845"

examples/bigtest/notebook.jl

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@ using DataFrames # for displaying tables
1616
# # Regression
1717

1818
known_problems = models() do model
19-
!model.is_pure_julia ||
19+
model.package_name in [
20+
"ScikitLearn",
21+
"LIBSVM",
22+
] ||
2023
any([
2124
# https://github.com/lalvim/PartialLeastSquaresRegressor.jl/issues/29
2225
model.package_name == "PartialLeastSquaresRegressor",
@@ -47,9 +50,11 @@ report1 |> DataFrame
4750
# # Classification
4851

4952
known_problems = models() do model
50-
!model.is_pure_julia ||
51-
(name = model.name, package_name = model.package_name) in
52-
[
53+
model.package_name in [
54+
"ScikitLearn",
55+
"LIBSVM",
56+
] || (name = model.name, package_name = model.package_name) in [
57+
5358
# https://github.com/JuliaAI/MLJMultivariateStatsInterface.jl/issues/41
5459
(name = "LDA", package_name = "MultivariateStats"),
5560
(name = "SubspaceLDA", package_name = "MultivariateStats"),

src/attemptors.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ end
129129
function evaluation(measure, model, resources, data...; throw=false, verbosity=1)
130130
L = length(resources)
131131
message = L > 1 ? "[:accelerated_evaluation] " : "[evaluation] "
132-
message *= "Evaluating model performance using with $L resources. "
132+
message *= "Evaluating model performance using $L different resources. "
133133
attempt(finalize(message, verbosity); throw) do
134134
es = map(resources) do accel
135135
evaluate(model, data...;
@@ -206,7 +206,7 @@ function stack_evaluation(
206206
L = length(resources)
207207
message = L > 1 ? "[:accelerated_stack_evaluation] " : "[stack_evaluation] "
208208
message *= "Evaluating a stack containing model "*
209-
"with $L resources. "
209+
"with $L different resources. "
210210
target_scitype = MLJ.target_scitype(model)
211211
if AbstractVector{Continuous} <: target_scitype
212212
models = (knn1=KNNRegressor(K=4),

0 commit comments

Comments
 (0)