Skip to content

Commit e6bdb96

Browse files
committed
fix type issue with julia 1.3, revert oldest version of julia supported to 1.3, change defaults for transformer
1 parent 31b7910 commit e6bdb96

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ MLJModelInterface = "1.3"
1515
ScientificTypesBase = "2.2.0"
1616
ScientificTypes = "2.2.2"
1717
TextAnalysis = "0.7.3"
18-
julia = "1.5"
18+
julia = "1.3"
1919

2020
[extras]
2121
MLJBase = "a7f614a8-145f-11e9-1d2a-a57a1082229d"

src/MLJText.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ zero divisions: `idf(t) = log [ (1 + n) / (1 + df(t)) ] + 1`.
4747
4848
"""
4949
MMI.@mlj_model mutable struct TfidfTransformer <: MLJModelInterface.Unsupervised
50-
max_doc_freq::Float64 = 0.98
51-
min_doc_freq::Float64 = 0.02
50+
max_doc_freq::Float64 = 1.0
51+
min_doc_freq::Float64 = 0.0
5252
smooth_idf::Bool = true
5353
end
5454

test/runtests.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ using TextAnalysis
5050
"in" => 1,
5151
"the cat" => 1
5252
)
53-
bag = Dict{MLJText.NGram, Int}(Tuple(String.(split(k))) => v for (k, v) in bag_of_words)
53+
bag = Dict(Tuple(String.(split(k))) => v for (k, v) in bag_of_words)
5454
tfidf_transformer2 = MLJText.TfidfTransformer()
5555
test_machine2 = @test_logs machine(tfidf_transformer2, [bag])
5656
MLJBase.fit!(test_machine2)

0 commit comments

Comments
 (0)