Skip to content

Conversation

@pebeto
Copy link
Member

@pebeto pebeto commented Nov 6, 2025

Upgrading the LTS version is something already mentioned in JuliaAI/MLJ.jl#1143.

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.29%. Comparing base (f44ad05) to head (04ada9b).
⚠️ Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #35      +/-   ##
==========================================
+ Coverage   87.95%   88.29%   +0.33%     
==========================================
  Files           8        8              
  Lines         191      188       -3     
==========================================
- Hits          168      166       -2     
+ Misses         23       22       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Can you please just remove nightly testing altogether. I don't think the benefits are worth it given our very limited bandwidth. See also https://discourse.julialang.org/t/why-do-packages-run-continuous-integration-tests-on-julia-nightly/101208/23?page=2

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me,

@ablaom ablaom merged commit 37fe3d4 into JuliaAI:dev Nov 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants