🔼 Change feat_levels to col_name

Author: EssamWisam

src/encoders/contrast_encoder/contrast_encoder.jl

@@ -65,7 +65,7 @@ Fit a contrast encoing scheme on given data in `X`.
   - `mode=:dummy`: The type of encoding to use. Can be one of `:contrast`, `:dummy`, `:sum`, `:backward_diff`, `:forward_diff`, `:helmert` or `:hypothesis`.
   If `ignore=false` (features to be encoded are listed explictly in `features`), then this can be a vector of the same length as `features` to specify a different
   contrast encoding scheme for each feature
-  - `buildmatrix=nothing`: A function that takes a vector of levels and the number of levels as input and should return a contrast or hypothesis matrix. 
+  - `buildmatrix=nothing`: A function that should take column name as a symbol and the number of levels as input and return a contrast or hypothesis matrix. 
   Only relevant if `mode` is `:contrast` or `:hypothesis`.
   - `ignore=true`: Whether to exclude or includes the features given in `features`
   - `ordered_factor=false`: Whether to encode `OrderedFactor` or ignore them
@@ -103,10 +103,10 @@ function contrast_encoder_fit(
         k = length(feat_levels)
         feat_mode = (mode_is_vector) ? mode[findfirst(isequal(name), features)] : mode
         if feat_mode == :contrast
-            contrastmatrix = buildmatrix(feat_levels, k)
+            contrastmatrix = buildmatrix(name, k)            
             size(contrastmatrix) == (k, k-1) || throw(ArgumentError(MATRIX_SIZE_ERROR(k, size(contrastmatrix), name)))
         elseif feat_mode == :hypothesis
-            hypothesismatrix = buildmatrix(feat_levels, k)
+            hypothesismatrix = buildmatrix(name, k) 
             size(hypothesismatrix) == (k-1, k) || throw(ArgumentError(MATRIX_SIZE_ERROR_HYP(k, size(hypothesismatrix), name)))
             contrastmatrix = pinv(hypothesismatrix)
         elseif feat_mode == :dummy

test/encoders/contrast_encoder.jl

@@ -11,7 +11,7 @@ age    = [23, 23, 14, 23])
 @testset "Contrast Encoder Error Handling" begin
 
     # Example definitions to allow the test to run
-    function dummy_buildmatrix(levels, k)
+    function dummy_buildmatrix(colname, k)
         # Simple dummy function to generate a matrix of correct size
         return randn(k, k-1)  # Adjust dimensions as needed for the test
     end
@@ -149,7 +149,7 @@ end
 @testset "contrast mode end-to-end test" begin
 
 
-    function buildrandomcontrast(feat_levels, k)
+    function buildrandomcontrast(colname, k)
         return rand(StableRNGs.StableRNG(123), k, k-1)
     end
 
@@ -174,7 +174,7 @@ end
 # @testset "hypothesis matrix end-to-end test"
 @testset "hypothesis mode end-to-end test" begin
 
-    function buildrandomhypothesis(feat_levels, k)
+    function buildrandomhypothesis(colname, k)
         return rand(StableRNGs.StableRNG(123), k-1, k)
     end    
 
@@ -194,11 +194,11 @@ end
 end
 
 
-function buildrandomhypothesis(feat_levels, k)
+function buildrandomhypothesis(colname, k)
     return rand(StableRNGs.StableRNG(123), k-1, k)
 end    
 
-function buildrandomcontrast(feat_levels, k)
+function buildrandomcontrast(colname, k)
     return rand(StableRNGs.StableRNG(123), k, k-1)
 end