Skip to content

Conversation

EssamWisam
Copy link
Collaborator

@ablaom check this out for #32

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the prompt attention.

@EssamWisam EssamWisam merged commit 20769cf into dev Jul 1, 2025
2 checks passed
@ablaom
Copy link
Member

ablaom commented Jul 10, 2025

Thanks again for this. Could you please confirm the following is a complete list of models for this package? If there are any missing, bad load_paths are again the likely culprits:

julia> MLJModelRegistry.update("MLJTransforms")
OrderedCollections.LittleDict{Any, Any, Vector{Any}, Vector{Any}} with 13 entries:
  "Standardizer"                   => LittleDict{Any, Any, Vector{Any}, Vector{Any}}(":inpu…
  "UnivariateTimeTypeToContinuous" => LittleDict{Any, Any, Vector{Any}, Vector{Any}}(":inpu
  "OneHotEncoder"                  => LittleDict{Any, Any, Vector{Any}, Vector{Any}}(":inpu…
  "FrequencyEncoder"               => LittleDict{Any, Any, Vector{Any}, Vector{Any}}(":inpu
  "TargetEncoder"                  => LittleDict{Any, Any, Vector{Any}, Vector{Any}}(":inpu…
  "UnivariateBoxCoxTransformer"    => LittleDict{Any, Any, Vector{Any}, Vector{Any}}(":inpu
  "InteractionTransformer"         => LittleDict{Any, Any, Vector{Any}, Vector{Any}}(":inpu…
  "UnivariateDiscretizer"          => LittleDict{Any, Any, Vector{Any}, Vector{Any}}(":inpu
  "CardinalityReducer"             => LittleDict{Any, Any, Vector{Any}, Vector{Any}}(":inpu…
  "OrdinalEncoder"                 => LittleDict{Any, Any, Vector{Any}, Vector{Any}}(":inpu
  "FillImputer"                    => LittleDict{Any, Any, Vector{Any}, Vector{Any}}(":inpu…
  "MissingnessEncoder"             => LittleDict{Any, Any, Vector{Any}, Vector{Any}}(":inpu
  "ContrastEncoder"                => LittleDict{Any, Any, Vector{Any}, Vector{Any}}(":inpu…

@EssamWisam
Copy link
Collaborator Author

Why is there no

metadata_model(ContinuousEncoder,
    input_scitype   = Table,
    output_scitype = Table(Continuous),
    load_path    = "MLJTransforms.ContinuousEncoder")

@EssamWisam
Copy link
Collaborator Author

There is also no BoxCoxTransformer but this one is indeed a bad path.

@ablaom
Copy link
Member

ablaom commented Jul 13, 2025

Why is there no...

Are you sure you are looking at the right branch? This is what I see on dev, which is a bad load path for ContinousEncoder:

load_path = "MLJModels.ContinuousEncoder")

Another possibility is that you have duplicate declarations ???

@ablaom
Copy link
Member

ablaom commented Jul 22, 2025

@EssamWisam Are you able to resolve these outstanding issues here soon, and to tag a new release? Preferably after merging #34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants