Bump [compat] entry: CategoricalArrays="1.0" #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
|
@ablaom in the ci tests we see |
|
Sorry, my bad. This PR needs:
@EssamWisam Let me ping you when this ready. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recall that CategoricalArrays 1.0 introduces new behaviour for
levels. The return value is aCategoricalArrayinstead of raw levels.As I am not familiar with the codebase for the newer encoders, I have simply replaced all calls
levelswithrawlevels, whererawlevelsmimics the old behaviour:rawlevels(A) = unwrap.(levels(A)).This PR is needed before important rollout of the CategoricalArrays="1.0" update can happen elsewhere in the MLJ ecosystem. In particular, MLJModels, needs this PR merged before it can do the update.