Skip to content

Conversation

@ablaom
Copy link
Member

@ablaom ablaom commented Dec 9, 2025

When tuning deeply nested hyper-parameters, the plots get horribly cluttered.

Before this PR:

Screenshot 2025-12-09 at 5 23 44 PM

After this PR:

Screenshot 2025-12-09 at 5 17 28 PM

@ablaom ablaom assigned ablaom and unassigned ablaom Dec 9, 2025
@ablaom ablaom requested a review from OkonSamuel December 9, 2025 04:26
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.44%. Comparing base (d4bd5c4) to head (1750557).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
src/plotrecipes.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #229      +/-   ##
==========================================
+ Coverage   87.34%   87.44%   +0.09%     
==========================================
  Files          13       13              
  Lines         664      677      +13     
==========================================
+ Hits          580      592      +12     
- Misses         84       85       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@OkonSamuel OkonSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!. I love your solution @ablaom.
This is a tricky problem as MLJ does not place any limit on the length of a model parameter, but the defaults you used are sufficient for most cases. I don't think most people will have a model with the innermost parameter having length greater that 20.
Anyways for more complicated setup the user can always adjust the plot width.

fits = true
end
end
""*join(reverse(parts), ".")
Copy link
Member

@OkonSamuel OkonSamuel Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the ellipsis unicode (i.e "\u2026" ) or just 3 dots?. If this isn't unicode ellipsis, we can get more space by using unicode ellipsis.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It the single character unicode character.

@ablaom ablaom merged commit 5a5cffe into dev Dec 16, 2025
4 checks passed
@ablaom
Copy link
Member Author

ablaom commented Dec 16, 2025

Thanks @OkonSamuel for your review.

This was referenced Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants