coefficienttype -> coefficient_type (#129)

* coefficienttype -> coefficient_type

* Remove incorrect method

Author: blegat

.github/workflows/ci.yml

@@ -52,6 +52,6 @@ jobs:
         with:
           depwarn: error
       - uses: julia-actions/julia-processcoverage@v1
-      - uses: codecov/codecov-action@v1
+      - uses: codecov/codecov-action@v3
         with:
           file: lcov.info

src/DynamicPolynomials.jl

@@ -35,7 +35,6 @@ MP.term_type(::Union{PolyType{C}, Type{<:PolyType{C}}}, ::Type{T}) where {C, T}
 MP.term_type(::Type{Polynomial{C}}) where {C} = Term{C}
 MP.polynomial_type(::Type{Term{C}}) where {C} = Polynomial{C}
 MP.polynomial_type(::Type{Term{C, T}}) where {T, C} = Polynomial{C, T}
-MP.polynomial_type(::Type{T}, ::Type{<:DMonomialLike{C}}) where {T, C} = Polynomial{C, T}
 MP.polynomial_type(::Union{PolyType{C}, Type{<:PolyType{C}}}, ::Type{T}) where {C, T} = Polynomial{C, T}
 _vars(p::AbstractArray{<:PolyType}) = mergevars(_vars.(p))[1]
 MP.variables(p::Union{PolyType, MonomialVector, AbstractArray{<:PolyType}}) = _vars(p) # tuple(_vars(p))

src/mult.jl

@@ -105,7 +105,7 @@ function Base.:(*)(p::Polynomial{true, S}, q::Polynomial{true, T}) where {S, T}
     if iszero(p) || iszero(q)
         zero(PT)
     else
-        polynomialclean(_mul(MP.coefficienttype(PT), p, q)...)
+        polynomialclean(_mul(MP.coefficient_type(PT), p, q)...)
     end
 end
 function MA.operate_to!(p::Polynomial{false, T}, ::typeof(*), q1::MP.AbstractPolynomialLike, q2::MP.AbstractPolynomialLike) where T

src/subs.jl

@@ -93,7 +93,7 @@ function _subs(::MP.Eval, p::Polynomial{C, T}, vals::AbstractVector{S}) where {C
     end
 end
 function _subs(::MP.Subs, p::Polynomial{C, T}, vals::AbstractVector{S}) where {C, T, S}
-    Tout = MA.promote_operation(*, T, MP.coefficienttype(S))
+    Tout = MA.promote_operation(*, T, MP.coefficient_type(S))
     q = zero_with_variables(Polynomial{C, Tout}, mergevars_of(PolyVar{C}, vals)[1])
     for i in 1:length(p.a)
         MA.operate!(+, q, p.a[i] * monoeval(p.x.Z[i], vals))

test/poly.jl

@@ -1,9 +1,9 @@
 @testset "Term and Polynomial tests" begin
     @testset "Term" begin
         @polyvar x
-#       @test coefficienttype(1x) == Int
-#       @test coefficienttype(1.0x^2) == Float64
-#       @test coefficienttype(Term{true, Int}) == Int
+#       @test coefficient_type(1x) == Int
+#       @test coefficient_type(1.0x^2) == Float64
+#       @test coefficient_type(Term{true, Int}) == Int
         @test zero_term(Term{false, Int}).α == 0
         @test one(Term{true, Int}).α == 1
         @polyvar x