Fix monomials with unsorted variables (#125)

* Fix monomials with unsorted variables

* CI change

* Remove test

Author: blegat

.github/workflows/ci.yml

@@ -46,7 +46,7 @@ jobs:
         shell: julia --project=@. {0}
         run: |
           using Pkg
-          Pkg.add(PackageSpec(name="MultivariatePolynomials", rev="master"))
+          Pkg.add(PackageSpec(name="MultivariatePolynomials", rev="bl/sort_vars_monomials"))
       - uses: julia-actions/julia-buildpkg@v1
       - uses: julia-actions/julia-runtest@v1
         with:

src/monovec.jl

@@ -137,6 +137,7 @@ function getZfordegs(n, degs::AbstractVector{Int}, ::Type{Val{C}}, filter::Funct
 end
 
 function MonomialVector(vars::Vector{PolyVar{true}}, degs::AbstractVector{Int}, filter::Function = x->true)
+    vars = unique!(sort(vars, rev=true))
     MonomialVector{true}(vars, getZfordegs(length(vars), degs, Val{true}, z -> filter(Monomial(vars, z))))
 end
 

test/mono.jl

@@ -76,7 +76,6 @@ using Test
     @testset "MonomialVector" begin
         @polyvar x y
         @test_throws AssertionError MonomialVector{true}([x], [[1], [1,0]])
-        @test_throws AssertionError monomials([y, x], 1:2) # should be [x, y]
         X = MonomialVector([x, 1, x*y])
         @test variables(X) == [x, y]
         @test X.Z == [[0, 0], [1, 0], [1, 1]]