fix: fix comparison involving NaN
#178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blegat
reviewed
Aug 9, 2025
test/comp.jl
Outdated
| @testset "Comparison with NaN" begin | ||
| @polyvar p | ||
| @test (NaN + p) != (NaN + p) | ||
| @test isequal(NaN + p, NaN + p) |
There was a problem hiding this comment.
Can you also check that it's allocation-free ? Sometimes Julia decides to not specialize on function arguments so if you add q = NaN + p and then @test 0 == @allocated q != q and @test 0 == @allocated isequal(q, q), it should make sure of that
|
Bump here as well :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #177
This only handles the case for comparing two polynomials. The rest of the changes need to be made in MultivariatePolynomials.jl