Merge pull request #117 from ahumenberger/master

Add missing methods for RationalPoly

Author: blegat

src/operators.jl

@@ -115,11 +115,13 @@ LinearAlgebra.adjoint(v::AbstractVariable) = v
 LinearAlgebra.adjoint(m::AbstractMonomial) = m
 LinearAlgebra.adjoint(t::AbstractTerm) = LinearAlgebra.adjoint(coefficient(t)) * monomial(t)
 LinearAlgebra.adjoint(p::AbstractPolynomialLike) = polynomial(map(LinearAlgebra.adjoint, terms(p)))
+LinearAlgebra.adjoint(r::RationalPoly) = adjoint(numerator(r)) / adjoint(denominator(r))
 
 LinearAlgebra.transpose(v::AbstractVariable) = v
 LinearAlgebra.transpose(m::AbstractMonomial) = m
 LinearAlgebra.transpose(t::AbstractTerm) = LinearAlgebra.transpose(coefficient(t)) * monomial(t)
 LinearAlgebra.transpose(p::AbstractPolynomialLike) = polynomial(map(LinearAlgebra.transpose, terms(p)))
+LinearAlgebra.transpose(r::RationalPoly) = transpose(numerator(r)) / transpose(denominator(r))
 
 LinearAlgebra.dot(p1::AbstractPolynomialLike, p2::AbstractPolynomialLike) = p1' * p2
 LinearAlgebra.dot(x, p::AbstractPolynomialLike) = x' * p

src/rational.jl

@@ -6,6 +6,9 @@ struct RationalPoly{NT <: APL, DT <: APL}
     den::DT
 end
 
+# This constructor is called from LinearAlgebra in the method Matrix{T}(s::UniformScaling{Bool}, dims)
+RationalPoly{NT,DT}(x::Bool) where {NT,DT} = ifelse(x, one(RationalPoly{NT,DT}), zero(RationalPoly{NT,DT}))
+
 Base.numerator(r::RationalPoly) = r.num
 Base.denominator(r::RationalPoly) = r.den
 
@@ -25,6 +28,7 @@ end
 Base.inv(r::RationalPoly) = r.den / r.num
 Base.inv(p::APL{T}) where T = one(T) / p
 Base.:/(r::RationalPoly, p) = r.num / (r.den * p)
+Base.:/(r::RationalPoly, s::RationalPoly) = (r.num * s.den) / (s.num * r.den)
 function Base.:/(num::NT, den::DT) where {NT <: APL, DT <: APL}
     RationalPoly{NT, DT}(num, den)
 end

test/rational.jl

@@ -26,4 +26,9 @@
     @test denominator(x / x^2) == x^2
     @test inv(x / x^2) == x
     @test x / x^2 == inv(x)
+    @test isone(((x+1) / (x-1)) / ((x+1) / (x-1)))
+    @test ((x+1)^2 / (x-1)) / ((x+1) / (x-1)) == x+1
+    RType = typeof(x+1/x)
+    @test RType(true) == one(RType)
+    @test RType(false) == zero(RType)
 end