fix: fix comparison involving NaN
#334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blegat
reviewed
Aug 9, 2025
test/commutative/comparison.jl
Outdated
| @test isequal(NaN * x, NaN * x + 0) | ||
| @test !=(NaN * x, NaN * x) | ||
| @test !=(NaN * x + 0, NaN * x + 0) | ||
| @test !=(NaN * x, NaN * x + 0) |
There was a problem hiding this comment.
Same comment for DynamicPolynomials, could you check that it's allocation free as well ?
There was a problem hiding this comment.
Fixed in 6d3e7f3
blegat
reviewed
Aug 9, 2025
| @test !=(NaN * x, NaN * x) | ||
| @test !=(NaN * x + 0, NaN * x + 0) | ||
| @test !=(NaN * x, NaN * x + 0) | ||
| end |
There was a problem hiding this comment.
Missing checks for RationalPoly it seems
There was a problem hiding this comment.
Fixed in 3cb3f49
|
Thanks ! Just a few minor comments but it looks good |
|
You can ignore the failure on nightly so just fix the format with JuliaFormatter@v2 |
AayushSabharwal
force-pushed
the
as/fix-isequal
branch
from
3cb3f49 to
e5da00a
Compare
|
Addressed the formatting issues |
|
Bump 😅 is there anything else left here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referring to JuliaAlgebra/DynamicPolynomials.jl#177
Some of the issues are fixed by JuliaAlgebra/DynamicPolynomials.jl#178. The rest require the changes in this PR.