Skip to content

fix: remove invalidating ::Any methods #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: remove invalidating ::Any methods #346

wants to merge 2 commits into from

Conversation

@AayushSabharwal
Copy link
Contributor

@AayushSabharwal AayushSabharwal commented Sep 20, 2025 •
edited
Loading

I also removed the ::Nothing method since it was invalidating, and if I understand correctly it was necessary due to the ::Any methods.

blegat
blegat reviewed Sep 20, 2025
View reviewed changes
src/comparison.jl Outdated
Base.isequal(α, q::RationalPoly) = isequal(α * q.den, q.num)
Base.isequal(q::RationalPoly, α) = isequal(α, q)
Base.isequal(α::Union{Number,MA.AbstractMutable,AbstractArray}, q::RationalPoly) = isequal(α * q.den, q.num)
Base.isequal(q::RationalPoly, α::Union{Number,MA.AbstractMutable,AbstractArray}) = isequal(α, q)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define this Union as a const const _Constant

@AayushSabharwal AayushSabharwal force-pushed the as/improve-invalidations branch 2 times, most recently from 9738765 to ed52a33 Compare September 20, 2025 20:55
@blegat
Copy link
Member

blegat commented Sep 22, 2025

Is the support of AbstractArray also causing invalidations ?

@AayushSabharwal
Copy link
Contributor Author

AayushSabharwal commented Sep 22, 2025 •
edited
Loading

No, that part is fine. The only other invalidations from this dependency tree are

inserting *(z::MutableArithmetics.Zero, ::Any) @ MutableArithmetics ~/.julia/packages/MutableArithmetics/PcwmY/src/rewrite.jl:61 invalidated:
   mt_backedges: 1: signature Tuple{typeof(*), Any, String} triggered MethodInstance for Base.Precompilation._precompilepkgs(::Vector{String}, ::Bool, ::Bool, ::Bool, ::Bool, ::Bool, ::Vector{Pair{Cmd, Base.CacheFlags}}, ::IOContext{IO}, ::Bool, ::Bool) (0 children)

inserting +(x, ::MutableArithmetics.Zero) @ MutableArithmetics ~/.julia/packages/MutableArithmetics/PcwmY/src/rewrite.jl:65 invalidated:
   mt_backedges: 1: signature Tuple{typeof(+), Ptr{UInt16}, Any} triggered MethodInstance for Base._copyfrompacked!(::Ptr, ::Ptr{UInt16}) (1 children)
                 2: signature Tuple{typeof(+), Ptr{Tuple{UInt8, UInt8}}, Any} triggered MethodInstance for Base._copyfrompacked!(::Ptr, ::Ptr{Tuple{UInt8, UInt8}}) (1 children)

inserting step(r::MutableArithmetics.MutatingStepRange) @ MutableArithmetics ~/.julia/packages/MutableArithmetics/PcwmY/src/implementations/MutatingStepRange.jl:25 invalidated:
   mt_backedges: 1: signature Tuple{typeof(step), OrdinalRange{Int64, Int64}} triggered MethodInstance for Base.IteratorsMD.__inc(::Tuple{Int64, Int64, Vararg{Int64}}, ::Tuple{OrdinalRange{Int64, Int64}, OrdinalRange{Int64, Int64}, Vararg{OrdinalRange{Int64, Int64}}}) (0 children)
                 2: signature Tuple{typeof(step), OrdinalRange{Int64, Int64}} triggered MethodInstance for (::Base.IteratorsMD.var"#23#25")(::OrdinalRange{Int64, Int64}) (3 children)
                 3: signature Tuple{typeof(step), OrdinalRange{Int64, Int64}} triggered MethodInstance for Base.IteratorsMD.__inc(::Tuple{Int64}, ::Tuple{OrdinalRange{Int64, Int64}}) (5 children)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blegat blegat blegat left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AayushSabharwal @blegat