Skip to content

Commit 1b2c853

Browse files
authored
Relax type checks in ApproxFunBaseTest (#347)
1 parent 8bd28de commit 1b2c853

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

.github/workflows/downstream.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ jobs:
5454
try
5555
# force it to use this PR's version of the package
5656
Pkg.develop(PackageSpec(path=".")) # resolver may fail with main deps
57+
Pkg.develop(PackageSpec(path="ApproxFunBaseTest"))
5758
Pkg.update()
5859
Pkg.test(; coverage = true) # resolver may fail with test time deps
5960
catch err

ApproxFunBaseTest/Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "ApproxFunBaseTest"
22
uuid = "a931bfaf-0cfd-4a5c-b69c-bf2eed002b43"
33
authors = ["Jishnu Bhattacharya <[email protected]>"]
4-
version = "0.1.2"
4+
version = "0.1.3"
55

66
[deps]
77
ApproxFunBase = "fbd15aa5-315a-5a7d-a8a4-24992e37be05"

ApproxFunBaseTest/src/ApproxFunBaseTest.jl

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Base.Experimental.@optlevel 1
55
using ApproxFunBase
66
using ApproxFunBase: plan_transform, plan_itransform, israggedbelow, RaggedMatrix, isbandedbelow, isbanded,
77
blockstart, blockstop, resizedata!
8-
using BandedMatrices: rowstart, rowstop, colstart, colstop, BandedMatrix, bandwidth
8+
using BandedMatrices: BandedMatrices, rowstart, rowstop, colstart, colstop, BandedMatrix, bandwidth
99
using BlockArrays
1010
using BlockArrays: blockrowstop, blockcolstop
1111
using BlockBandedMatrices
@@ -238,7 +238,8 @@ function testbandedoperator(A)
238238
@test rowstop(A,k) k + bandwidth(A,2)
239239
end
240240

241-
@test isa(A[1:10,1:10],BandedMatrix)
241+
Am = A[1:10,1:10]
242+
@test Am isa AbstractMatrix && BandedMatrices.isbanded(Am)
242243
end
243244

244245

@@ -263,7 +264,8 @@ function testbandedblockbandedoperator(A)
263264
@test isfinite(subblockbandwidth(A,1))
264265
@test isfinite(subblockbandwidth(A,2))
265266

266-
@test isa(A[Block.(1:4),Block.(1:4)], BandedBlockBandedMatrix)
267+
Am = A[Block.(1:4),Block.(1:4)]
268+
@test Am isa AbstractMatrix && isbandedblockbanded(Am)
267269
end
268270

269271
end # module

0 commit comments

Comments
 (0)