vector indexing for transpose op (#173)

Author: jishnub

src/Operators/functionals/Evaluation.jl

@@ -57,8 +57,12 @@ end
 
 
 ## default getindex
-getindex(D::ConcreteEvaluation,k::Integer) =
-    eltype(D)(differentiate(Fun(D.space,[zeros(eltype(D),k-1);one(eltype(D))]),D.order)(D.x))
+function getindex(D::ConcreteEvaluation,k::Integer)
+    f = Fun(D.space, [zeros(eltype(D),k-1); one(eltype(D))])
+    df = differentiate(f,D.order)
+    v = df(D.x)
+    strictconvert(eltype(D), v)
+end
 
 #special leftendpoint/rightendpoint overrides
 for (dop, fop) in ((:leftendpoint,:first), (:rightendpoint,:last))

src/Operators/general/OperatorLayout.jl

@@ -105,6 +105,7 @@ domain(P::TransposeOperator)=domain(P.op)
 bandwidths(P::TransposeOperator) = reverse(bandwidths(P.op))
 
 getindex(P::TransposeOperator,k::Integer,j::Integer) = P.op[j,k]
+getindex(P::TransposeOperator,inds...) = transpose(P.op[reverse(inds)...])
 
 function BandedMatrix(S::SubOperator{T,TO}) where {T,TO<:TransposeOperator}
     kr,jr=parentindices(S)

src/Spaces/DiracSpace.jl

@@ -81,7 +81,7 @@ values(f::Fun{S}) where S<:PointSpace = coefficient(f,:)
 
 function evaluate(f::AbstractVector,PS::PointSpace,x::Number)
     p = findfirst(y->isapprox(x,y),PS.points)
-    if p == 0 || p > length(f)
+    if p === nothing
         zero(eltype(f))
     else
         f[p]
@@ -92,7 +92,7 @@ function evaluate(f::AbstractVector, PS::DiracSpace, x::Number)
     x ∉ domain(PS) && return zero(eltype(f))
 
     p = findfirst(y->isapprox(x,y), PS.points)
-    if p == 0 || p > length(f)
+    if p === nothing
         zero(eltype(f))
     else
         f[p]*Inf

test/SpacesTest.jl

@@ -118,6 +118,21 @@ using BandedMatrices: rowrange, colrange
             f = Fun(PointSpace(1:3), SA[1,2,3])
             @test coefficients(f^2) == coefficients(f).^2
         end
+
+        @testset "indexing outside bounds" begin
+            f = Fun(PointSpace(1:3), Float64[1:3;])
+            @test f(0) == 0
+            @test f(1) == 1
+            @test f(4) == 0
+        end
+    end
+
+    @testset "DiracSpace" begin
+        f = Fun(ApproxFunBase.DiracSpace(Float64[-1,0,1]), Float64[1,2,3])
+        @test f(-5) == 0
+        @test f(0.5) == 0
+        @test f(5) == 0
+        @test isinf(f(0))
     end
 
     @testset "Derivative operator for HeavisideSpace" begin

test/show.jl

@@ -59,6 +59,11 @@
 			summarystr = ApproxFunBase.summarystr(EA)
 			show(io, MIME"text/plain"(), EA)
 			@test contains(String(take!(io)), summarystr)
+
+			EA = transpose(Evaluation(Chebyshev(), 0))
+			summarystr = ApproxFunBase.summarystr(EA)
+			show(io, MIME"text/plain"(), EA)
+			@test contains(String(take!(io)), summarystr)
 		end
 		@testset "QuotientSpace" begin
 			Q = QuotientSpace(Dirichlet(ConstantSpace(0..1)))