Skip to content

Commit 5d3c101

Browse files
authored
restore QR on old julia versions (#116)
1 parent 21def24 commit 5d3c101

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

.github/workflows/downstream.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
strategy:
1717
fail-fast: true
1818
matrix:
19-
julia-version: [1]
19+
julia-version: [1, 1.6]
2020
os: [ubuntu-latest]
2121
package:
2222
- {repo: ApproxFun.jl, group: JuliaApproximation}

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "ApproxFunBase"
22
uuid = "fbd15aa5-315a-5a7d-a8a4-24992e37be05"
3-
version = "0.5.12"
3+
version = "0.5.13"
44

55
[deps]
66
AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"

src/Operators/nullspace.jl

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
11

2-
2+
if VERSION >= v"1.7"
3+
_qrcolnorm(K) = qr(K, ColumnNorm())
4+
else
5+
_qrcolnorm(K) = qr(K, Val(true))
6+
end
37
function nullspace(A::Operator{T};tolerance=10eps(real(T)),maxlength=1_000_000) where T
4-
K=transpose_nullspace(qr(A'),tolerance,maxlength)
8+
K=transpose_nullspace(qr(A'),tolerance,maxlength)
59
# drop extra rows, and use QR to determine rank
6-
Q,R = qr(K, ColumnNorm())
10+
Q,R = _qrcolnorm(K)
711
ind=findfirst(r->abs(r)100tolerance,diag(R))
812
Kret=ind==0 ? Q : Q[:,1:ind-1]
913
Fun(Space(fill(domainspace(A),(1,ind-1))),vec(Kret'))

0 commit comments

Comments
 (0)