Skip to content

Commit 7ced245

Browse files
authored
import rad2deg/deg2rad from Base (#153)
1 parent c72cbc0 commit 7ced245

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

src/ApproxFunBase.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import Base: values, convert, getindex, setindex!, *, +, -, ==, <, <=, >, |, !,
2626
getproperty, findfirst, unsafe_getindex, fld, cld, div, imag,
2727
@_inline_meta, eachindex, firstindex, lastindex, keys, isreal, OneTo,
2828
Array, Vector, Matrix, view, ones, @propagate_inbounds, print_array,
29-
split, iszero, permutedims
29+
split, iszero, permutedims, rad2deg, deg2rad
3030

3131
import Base.Broadcast: BroadcastStyle, Broadcasted, AbstractArrayStyle, broadcastable,
3232
DefaultArrayStyle, broadcasted

src/Operators/ldiv.jl

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,22 @@
22
for TYP in (:Fun,:StridedVector,:AbstractVector,:Any)
33
@eval function \(A::Operator,b::$TYP;kwds...)
44
if isambiguous(domainspace(A))
5-
A=choosespaces(A,b)
6-
if isambiguous(domainspace(A))
5+
A2=choosespaces(A,b)
6+
if isambiguous(domainspace(A2))
77
error("Cannot infer spaces")
88
end
9-
\(A,b;kwds...)
9+
ldiv_nonambiguous(A2, b; kwds...)
1010
else
11-
Fun(domainspace(A),
12-
ldiv_coefficients(A,coefficients(b,rangespace(A));kwds...))
11+
ldiv_nonambiguous(A, b; kwds...)
1312
end
1413
end
1514
end
1615

16+
function ldiv_nonambiguous(A, b; kwds...)
17+
Fun(domainspace(A),
18+
ldiv_coefficients(A,coefficients(b,rangespace(A));kwds...))
19+
end
20+
1721
"""
1822
\\(A::Operator,b;tolerance=tol,maxlength=n)
1923

src/specialfunctions.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,8 +256,8 @@ for (op,oprecip,opinv,opinvrecip) in ((:(sin),:(csc),:(asin),:(acsc)),
256256
end
257257
end
258258

259-
rad2deg(f::Fun) = 180*f/π
260-
deg2rad(f::Fun) = π*f/180
259+
rad2deg(f::Fun) = 180/π*f
260+
deg2rad(f::Fun) = π/180*f
261261

262262
for (op,opd,opinv,opinvd) in ((:(sin),:(sind),:(asin),:(asind)),
263263
(:(cos),:(cosd),:(acos),:(acosd)),

0 commit comments

Comments
 (0)