optimize sort for tuples of spaces (#322)

* optimize sort for tuples of spaces

* Add tests

Author: jishnub

src/Spaces/SumSpace.jl

@@ -172,14 +172,9 @@ function spacescompatible(A::Tuple,B::Tuple)
         return false
     end
     #assumes domain doesn't impact sorting
-    asort=sort(collect(A));bsort=sort(collect(B))
-    for k=1:length(asort)
-        if !spacescompatible(asort[k],bsort[k])
-            return false
-        end
-    end
-
-    return true
+    asort=sort(SVector(A))
+    bsort=sort(SVector(B))
+    all(((x,y),) -> spacescompatible(x,y), zip(asort, bsort))
 end
 
 

src/show.jl

@@ -157,11 +157,17 @@ end
 
 function show(io::IO,ss::PiecewiseSpace)
     s = components(ss)
+    if length(s) == 1
+        print(io, "PiecewiseSpace(")
+    end
     show(io,s[1])
     for sp in s[2:end]
         print(io,"⨄")
         show(io,sp)
     end
+    if length(s) == 1
+        print(io, ")")
+    end
 end
 
 summarystr(ss::ArraySpace) = string(Base.dims2string(length.(axes(ss))), " ArraySpace")

test/SpacesTest.jl

@@ -263,6 +263,8 @@ using LinearAlgebra
         @testset "spacescompatible for TensorSpace" begin
             a = PointSpace(1:4)^2
             @test ApproxFunBase.spacescompatible(a, a)
+            @test ApproxFunBase.spacescompatible((a, a))
+            @test ApproxFunBase.spacescompatible((a, a), (a, a))
             b = PointSpace(1:4) ⊗ PointSpace(1:3)
             @test !ApproxFunBase.spacescompatible(a, b)
             @test a == a

test/show.jl

@@ -28,6 +28,13 @@
 			@test length(v) == 2
 			@test all(==(repr(S1)), v)
 		end
+		@testset "PiecewiseSpace" begin
+			p = PointSpace(1:4)
+			ps = PiecewiseSpace(p)
+			rpr = repr(ps)
+			@test contains(rpr, "PiecewiseSpace")
+			@test contains(rpr, repr(p))
+		end
 	end
 	@testset "Fun" begin
 		f = Fun(PointSpace(1:3), [1,2,3])