isdiag for deriv/integral (#71)

Author: jishnub

Project.toml

@@ -1,6 +1,6 @@
 name = "ApproxFunFourier"
 uuid = "59844689-9c9d-51bf-9583-5b794ec66d30"
-version = "0.3.9"
+version = "0.3.10"
 
 [deps]
 AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"

src/ApproxFunFourier.jl

@@ -46,7 +46,7 @@ import Base: convert, getindex, *, +, -, ==,  /, eltype,
             show, sum, cumsum, conj, issubset, first, last, rand, setdiff,
             angle, isempty, zeros, one, promote_rule, real, imag
 
-import LinearAlgebra: norm, mul!
+import LinearAlgebra: norm, mul!, isdiag
 
 using InfiniteArrays: AbstractInfUnitRange
 

src/FourierOperators.jl

@@ -88,6 +88,7 @@ getindex(C::ConcreteConversion{Fourier{DD,R1},Fourier{DD,R2},T},k::Integer,j::In
 
 function Derivative(S::Union{CosSpace,SinSpace},order)
     @assert isa(domain(S),PeriodicSegment)
+    @assert order > 0 "order of derivative must be > 0"
     ConcreteDerivative(S,order)
 end
 
@@ -138,6 +139,7 @@ end
 # Use Laurent derivative
 function Derivative(S::Fourier{<:Circle}, k::Number)
     assert_integer(k)
+    @assert k > 0 "order of derivative must be > 0"
     DerivativeWrapper(Derivative(Laurent(S),k)*Conversion(S,Laurent(S)),k)
 end
 
@@ -146,6 +148,7 @@ Integral(::CosSpace, m::Number) =
 
 function Integral(sp::SinSpace{<:PeriodicSegment}, m::Number)
     assert_integer(m)
+    @assert m > 0 "order of integral must be > 0"
     ConcreteIntegral(sp,m)
 end
 
@@ -174,7 +177,8 @@ function getindex(D::ConcreteIntegral{CS,OT,T},k::Integer,j::Integer) where {CS<
 end
 
 function Integral(S::SubSpace{<:CosSpace,<:AbstractInfUnitRange{Int},<:PeriodicSegment},k::Number)
-    @assert Integer(k) == k "order must be an integer"
+    assert_integer(k)
+    @assert k > 0 "order of integral must be > 0"
     @assert first(S.indexes)==2
     ConcreteIntegral(S,k)
 end

src/LaurentOperators.jl

@@ -69,14 +69,17 @@ coefficienttimes(f::Fun{Laurent{DD,RR}},g::Fun{Laurent{DD,RR}}) where {DD,RR} =
 # override map definition
 function Derivative(S::Hardy{<:Any,<:Circle}, k::Number)
     assert_integer(k)
+    @assert k > 0 " order of derivative must be > 0"
     ConcreteDerivative(S,k)
 end
 function Derivative(S::Hardy{<:Any,<:PeriodicSegment}, k::Number)
     assert_integer(k)
+    @assert k > 0 " order of derivative must be > 0"
     ConcreteDerivative(S,k)
 end
 function Derivative(S::Laurent{<:Circle}, k::Number)
     assert_integer(k)
+    @assert k > 0 " order of derivative must be > 0"
     t = map(s->Derivative(s,k), S.spaces)
     v = convert_vector_or_svector(t)
     D = Diagonal(v)
@@ -85,7 +88,8 @@ function Derivative(S::Laurent{<:Circle}, k::Number)
 end
 
 bandwidths(D::ConcreteDerivative{Hardy{s,DD,RR}}) where {s,DD<:PeriodicSegment,RR}=(0,0)
-bandwidths(D::ConcreteDerivative{Hardy{s,DD,RR}}) where {s,DD<:Circle,RR}=s ? (-D.order,D.order) : (D.order,-D.order)
+bandwidths(D::ConcreteDerivative{Hardy{s,DD,RR}}) where {s,DD<:Circle,RR} = s ? (-D.order,D.order) : (D.order,-D.order)
+isdiag(D::ConcreteDerivative{Hardy{s,DD,RR}}) where {s,DD<:Circle,RR} = false
 
 rangespace(D::ConcreteDerivative{S}) where {S<:Hardy}=D.space
 
@@ -151,10 +155,12 @@ getindex(D::ConcreteDerivative{Hardy{false,DD,RR},OT,T},k::Integer,j::Integer) w
 
 function Integral(S::Hardy{s,DD,RR}, k::Number) where {s,DD<:Circle,RR}
     assert_integer(k)
+    @assert k > 0 "order of integral must be > 0"
     ConcreteIntegral(S,k)
 end
 
 bandwidths(D::ConcreteIntegral{Taylor{DD,RR}}) where {DD<:Circle,RR} = (D.order,0)
+isdiag(D::ConcreteIntegral{Taylor{DD,RR}}) where {DD<:Circle,RR} = false
 rangespace(Q::ConcreteIntegral{Hardy{s,DD,RR}}) where {s,DD<:Circle,RR} = Q.space
 
 function getindex(D::ConcreteIntegral{Taylor{DD,RR}},k::Integer,j::Integer) where {DD<:Circle,RR}
@@ -177,6 +183,7 @@ end
 
 function Integral(S::SubSpace{<:Hardy{false,<:Circle}, <:AbstractInfUnitRange{Int}}, k::Number)
     assert_integer(k)
+    @assert k > 0 "order of integral must be > 0"
     if first(S.indexes) == k+1
         ConcreteIntegral(S,k)
     else