rename isapproxinteger_addhalf to isapproxhalfoddinteger (#63)

Author: jishnub

Project.toml

@@ -1,13 +1,15 @@
 name = "ApproxFunSingularities"
 uuid = "f8fcb915-6b99-5be2-b79a-d6dbef8e6e7e"
-version = "0.3.10"
+version = "0.3.11"
 
 [deps]
 ApproxFunBase = "fbd15aa5-315a-5a7d-a8a4-24992e37be05"
 ApproxFunOrthogonalPolynomials = "b70543e2-c0d9-56b8-a290-0d4d6d4de211"
 DomainSets = "5b8099bc-c8ec-5219-889f-1d9e522a28bf"
+HalfIntegers = "f0d1745a-41c9-11e9-1dd9-e5d34d218721"
 IntervalSets = "8197267c-284f-5f27-9208-e0e47529a953"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
+OddEvenIntegers = "8d37c425-f37a-4ca2-9b9d-a61bc06559d2"
 Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
 SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b"
 StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
@@ -19,7 +21,9 @@ ApproxFunBaseTest = "0.1"
 ApproxFunOrthogonalPolynomials = "0.2.3, 0.3, 0.4, 0.5, 0.6"
 Aqua = "0.6"
 DomainSets = "0.4, 0.5, 0.6"
+HalfIntegers = "1.5"
 IntervalSets = "0.5, 0.6, 0.7"
+OddEvenIntegers = "0.1.8"
 Reexport = "0.2, 1"
 SpecialFunctions = "1, 2"
 StaticArrays = "1"

src/ApproxFunSingularities.jl

@@ -40,10 +40,16 @@ import Base: convert, getindex, *, /, ^,
 
 using StaticArrays: SVector
 
+using HalfIntegers
+using OddEvenIntegers
+
+const HalfOddInteger{T<:Integer} = Half{Odd{T}}
+
 strictconvert(::Type{T}, x) where {T} = convert(T, x)::T
 
-isapproxinteger_addhalf(a) = isapproxinteger(a + 0.5)
-isapproxinteger_addhalf(::Integer) = false
+isapproxhalfoddinteger(a) = isapproxinteger(a + half(Odd(1)))
+isapproxhalfoddinteger(::HalfOddInteger) = true
+isapproxhalfoddinteger(::Integer) = false
 
 isequalminhalf(x) = x == -0.5
 isequalminhalf(::Integer) = false

src/JacobiWeightOperators.jl

@@ -431,7 +431,7 @@ for (Func,Len,Sum) in ((:DefiniteIntegral,:complexlength,:sum),(:DefiniteLineInt
         function bandwidths(Σ::$ConcFunc{<:JacobiWeight{<:Ultraspherical{<:Any,D,R},D,R}}) where {D<:IntervalOrSegment,R}
             λ = order(domainspace(Σ).space)
             β,α = domainspace(Σ).β,domainspace(Σ).α
-            if isapproxinteger_addhalf(β-λ) && β==α && λ ≤ ceil(Int,β)
+            if isapproxhalfoddinteger(β-λ) && β==α && λ ≤ ceil(Int,β)
                 0,2*(ceil(Int,β)-λ)
             else
                 0,∞
@@ -466,7 +466,7 @@ for (Func,Len,Sum) in ((:DefiniteIntegral,:complexlength,:sum),(:DefiniteLineInt
 
         function bandwidths(Σ::$ConcFunc{<:JacobiWeight{Chebyshev{D,R},D,R}}) where {D<:IntervalOrSegment,R}
             β,α = domainspace(Σ).β,domainspace(Σ).α
-            if isapproxinteger_addhalf(β) && β==α && 0 ≤ ceil(Int,β)
+            if isapproxhalfoddinteger(β) && β==α && 0 ≤ ceil(Int,β)
                 0,2ceil(Int,β)
             else
                 0,∞

test/runtests.jl

@@ -490,7 +490,7 @@ end
             @test ApproxFunBase.rowstop(B,1) == 1
             B[1] == arclength(domain(S))
             f = Fun(exp, S)
-            B*f == sum(Fun(exp,domain(S)))
+            @test convert(Number, B*f) ≈ sum(Fun(exp,domain(S)))
         end
     end
 end